Refined Storage

Refined Storage

77M Downloads

Disk Drive Lighting Issue

lurr opened this issue ยท 13 comments

commented

Issue description:

The Disks in Disk Drives lose lighting when the block behind has a light value of zero.

What happens:

The Disks front face (with smooth lighting enabled) goes dark.

What you expected to happen:

I expected the disks front face to obey lighting from the front side.

Steps to reproduce:

  1. Enable Smooth Lighting
  2. Place down Disk Drive
  3. Insert some disks
  4. Place blocks to make the block behind have a light value of zero.

Demonstration of the bug: YouTube

Version (Make sure you are on the latest version before reporting):

  • Minecraft: 1.10.2
  • Forge: 12.18.3.2221
  • Refined Storage: 1.2.21

Does this issue occur on a server? [yes/no] This is clientside.

commented

Workaround: face south when you place your disk drive. For whatever reason, the lighting issue with optifine only manifests if you're facing the other 3 directions.

commented

No, its not just a optifine issue, i hava not installed optifine, and i have too this issue, and much more bigger than that.

commented

Here is the screenshot:
2023-01-06_11 48 44

I have 281 mods installed :D, maybe some mod causing this??

commented

This happens with the Disk Manipulator too

commented

@shartte Sorry for pinging you this way, but since you did something similair for the models in AE, would you know what causes this?

commented

Uh good question...
How exactly did you implement this? Can you point me to the source?
p.s.: First guess would be that the cardinal direction (for culling) is not set correctly on the quads, or rather, they're sorted into the wrong list in the BakedModel.

commented

Okay it's hard to tell from just glancing at the code. I don't know how you are rotating the models around. When the rotation is applied, it's necessary to make sure that the quad facing is correctly rotated as well.

commented

Pure Optifine issue

With optifine installed:
blame optifine
Without optifine installed:
gud
gud2

commented

@sp614x do you know why this happens?

commented

This happens because OptiFine disables the Forge lighting pipeline which breaks way too many Optifine features.

More details:
#503
sp614x/optifine#298
AppliedEnergistics/Applied-Energistics-2#2489
sp614x/optifine#302

commented

Is there anything I can do RS side?

commented

Closing as this is a optifine issue.