Disk Drive Lighting Issue
lurr opened this issue ยท 13 comments
Issue description:
The Disks in Disk Drives lose lighting when the block behind has a light value of zero.
What happens:
The Disks front face (with smooth lighting enabled) goes dark.
What you expected to happen:
I expected the disks front face to obey lighting from the front side.
Steps to reproduce:
- Enable Smooth Lighting
- Place down Disk Drive
- Insert some disks
- Place blocks to make the block behind have a light value of zero.
Demonstration of the bug: YouTube
Version (Make sure you are on the latest version before reporting):
- Minecraft: 1.10.2
- Forge: 12.18.3.2221
- Refined Storage: 1.2.21
Does this issue occur on a server? [yes/no] This is clientside.
Workaround: face south when you place your disk drive. For whatever reason, the lighting issue with optifine only manifests if you're facing the other 3 directions.
No, its not just a optifine issue, i hava not installed optifine, and i have too this issue, and much more bigger than that.
@shartte Sorry for pinging you this way, but since you did something similair for the models in AE, would you know what causes this?
Uh good question...
How exactly did you implement this? Can you point me to the source?
p.s.: First guess would be that the cardinal direction (for culling) is not set correctly on the quads, or rather, they're sorted into the wrong list in the BakedModel.
The baked model:
https://github.com/raoulvdberge/refinedstorage/blob/mc1.11/src/main/java/com/raoulvdberge/refinedstorage/render/BakedModelDiskDrive.java
The regular model:
https://github.com/raoulvdberge/refinedstorage/blob/mc1.11/src/main/java/com/raoulvdberge/refinedstorage/render/ModelDiskDrive.java
Okay it's hard to tell from just glancing at the code. I don't know how you are rotating the models around. When the rotation is applied, it's necessary to make sure that the quad facing is correctly rotated as well.
@sp614x do you know why this happens?
This happens because OptiFine disables the Forge lighting pipeline which breaks way too many Optifine features.
More details:
#503
sp614x/optifine#298
AppliedEnergistics/Applied-Energistics-2#2489
sp614x/optifine#302