Refined Storage

Refined Storage

115M Downloads

1.20.1 and newer RF2’s grid will not trigger vanilla’s recipe crafted advancement triggers

Closed this issue · 1 comments

commented

Describe the bug

In player’s class, there is a triggerRecipeCrafted method that vanilla fires when player crafts stuff. This activates the recipe craft advancement trigger in vanilla

My mod hooks into this method for matching vanilla activation when counting how many times a player crafts a specific recipe of mine.

RS2’s grid appears to not call this vanilla method which can confuse players as to why recipe crafted advancements don’t work in the grid

How can we reproduce this bug or crash?

Make an advancement use recipe crafted trigger. Craft the recipe in ae2’s grid. Advancement not granted

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

All versions

What Refined Storage version is this happening on?

All versions

Relevant log output

commented

This should've been working, but this was broken in various ways. Fixed now.