Refined Storage

Refined Storage

Mods
115M Downloads

When attaching a pipe to network storage and the pipe has a type but no amount the server crashes with "Amount must be larger than 0"

MarkSG93 opened this issue ยท 0 comments

commented

Describe the bug

When attaching a pipe to network storage and the pipe has a type but no amount the server crashes with "Amount must be larger than 0". This also prevents the server from rebooting and causes it to crash on start-up.
This specifically happened with Modern Industrialization pipes.

How can we reproduce this bug or crash?

  1. Setup a RS network that accepts fluids via pipes.
  2. Add an empty fluid disk to the network.
  3. Attach a Modern Industrialization pipe to the network and set the fluid type of the pipe (This puts a fluid "item" into the pipe of amount zero).
  4. Crash.

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

NeoForge 21.1.145

What Refined Storage version is this happening on?

v2.0.0-beta.2

Relevant log output

java.lang.IllegalArgumentException: Amount must be larger than 0
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.api.core.CoreValidations.validateLargerThanZero(CoreValidations.java:55) ~[refinedstorage-neoforge-2.0.0-beta.2.jar%23808!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.api.resource.ResourceAmount.validate(ResourceAmount.java:21) ~[refinedstorage-neoforge-2.0.0-beta.2.jar%23808!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.api.resource.ResourceAmount.<init>(ResourceAmount.java:17) ~[refinedstorage-neoforge-2.0.0-beta.2.jar%23808!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.support.resource.ResourceContainerImpl.insertIntoEmptySlot(ResourceContainerImpl.java:326) ~[refinedstorage-neoforge-2.0.0-beta.2.jar%23808!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.support.resource.ResourceContainerImpl.insert(ResourceContainerImpl.java:303) ~[refinedstorage-neoforge-2.0.0-beta.2.jar%23808!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.neoforge.support.resource.ResourceContainerFluidHandlerAdapter.fill(ResourceContainerFluidHandlerAdapter.java:55) ~[refinedstorage-neoforge-2.0.0-beta.2.jar%23808!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.util.IOFluidHandler.fill(IOFluidHandler.java:61) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.pipes.fluid.FluidNetwork$TransferOperation.lambda$static$0(FluidNetwork.java:177) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.pipes.fluid.FluidNetwork.transferForBucket(FluidNetwork.java:167) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.pipes.fluid.FluidNetwork.transferByPriority(FluidNetwork.java:136) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.pipes.fluid.FluidNetwork.tick(FluidNetwork.java:90) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.pipes.api.PipeNetworkManager.tickNetworks(PipeNetworkManager.java:70) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/aztech.modern_industrialization.pipes.impl.PipeNetworks.lambda$static$2(PipeNetworks.java:121) ~[Modern-Industrialization-2.3.2.jar%23751!/:?] {re:classloading}
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.ConsumerEventHandler.invoke(ConsumerEventHandler.java:26) ~[bus-8.0.2.jar%2367!/:?] {}
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:350) ~[bus-8.0.2.jar%2367!/:?] {}
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:315) ~[bus-8.0.2.jar%2367!/:?] {}
	at TRANSFORMER/[email protected]/net.neoforged.neoforge.event.EventHooks.fireLevelTickPost(EventHooks.java:982) ~[neoforge-21.1.145-universal.jar%23508!/:?] {re:mixin,re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1043) ~[server-1.21.1-20240808.144430-srg.jar%23507!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:servercore.common.mixins.json:features.misc.MinecraftServerMixin from mod servercore,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:structureessentials.mixins.json:LevelCreatedCallback from mod structureessentials,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:ichunutil.mixins.json:MinecraftServerAccessorMixin from mod ichunutil,pl:mixin:APP:ponder.mixins.json:accessor.MinecraftServerAccessor from mod ponder,pl:mixin:APP:balm.neoforge.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:servercore.common.mixins.json:MinecraftServerMixin from mod servercore,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:ae2.mixins.json:spatial.MinecraftServerMixin from mod ae2,pl:mixin:APP:extended_industrialization.mixins.json:TeslaNetworkHolderMinecraftServerMixin from mod extended_industrialization,pl:mixin:A}
	at TRANSFORMER/[email protected]/net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:320) ~[server-1.21.1-20240808.144430-srg.jar%23507!/:?] {re:mixin,re:classloading,pl:mixin:A}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:917) ~[server-1.21.1-20240808.144430-srg.jar%23507!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:servercore.common.mixins.json:features.misc.MinecraftServerMixin from mod servercore,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:structureessentials.mixins.json:LevelCreatedCallback from mod structureessentials,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:ichunutil.mixins.json:MinecraftServerAccessorMixin from mod ichunutil,pl:mixin:APP:ponder.mixins.json:accessor.MinecraftServerAccessor from mod ponder,pl:mixin:APP:balm.neoforge.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:servercore.common.mixins.json:MinecraftServerMixin from mod servercore,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:ae2.mixins.json:spatial.MinecraftServerMixin from mod ae2,pl:mixin:APP:extended_industrialization.mixins.json:TeslaNetworkHolderMinecraftServerMixin from mod extended_industrialization,pl:mixin:A}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:707) ~[server-1.21.1-20240808.144430-srg.jar%23507!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:servercore.common.mixins.json:features.misc.MinecraftServerMixin from mod servercore,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:structureessentials.mixins.json:LevelCreatedCallback from mod structureessentials,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:ichunutil.mixins.json:MinecraftServerAccessorMixin from mod ichunutil,pl:mixin:APP:ponder.mixins.json:accessor.MinecraftServerAccessor from mod ponder,pl:mixin:APP:balm.neoforge.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:servercore.common.mixins.json:MinecraftServerMixin from mod servercore,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:ae2.mixins.json:spatial.MinecraftServerMixin from mod ae2,pl:mixin:APP:extended_industrialization.mixins.json:TeslaNetworkHolderMinecraftServerMixin from mod extended_industrialization,pl:mixin:A}
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:267) ~[server-1.21.1-20240808.144430-srg.jar%23507!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:servercore.common.mixins.json:features.misc.MinecraftServerMixin from mod servercore,pl:mixin:APP:modernfix-common.mixins.json:core.MinecraftServerMixin from mod modernfix,pl:mixin:APP:modernfix-common.mixins.json:perf.dedicated_reload_executor.MinecraftServerMixin from mod modernfix,pl:mixin:APP:fabric-message-api-v1.mixins.json:MinecraftServerMixin from mod fabric_message_api_v1,pl:mixin:APP:structureessentials.mixins.json:LevelCreatedCallback from mod structureessentials,pl:mixin:APP:fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric_resource_loader_v0,pl:mixin:APP:ichunutil.mixins.json:MinecraftServerAccessorMixin from mod ichunutil,pl:mixin:APP:ponder.mixins.json:accessor.MinecraftServerAccessor from mod ponder,pl:mixin:APP:balm.neoforge.mixins.json:MinecraftServerMixin from mod balm,pl:mixin:APP:servercore.common.mixins.json:MinecraftServerMixin from mod servercore,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:MinecraftServerMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:kubejs.mixins.json:MinecraftServerMixin from mod kubejs,pl:mixin:APP:ae2.mixins.json:spatial.MinecraftServerMixin from mod ae2,pl:mixin:APP:extended_industrialization.mixins.json:TeslaNetworkHolderMinecraftServerMixin from mod extended_industrialization,pl:mixin:A}
	at java.base/java.lang.Thread.run(Unknown Source) [?:?] {re:mixin}