Describe the bug

Some mods modify the stackability of Water Buckets, allowing them to be stacked even beyond 64. Attempting to craft salt in this situation will cause the bucket not to be returned when crafting is complete.

To Reproduce

1. Install a mod that allows Water Buckets to stack (I used Confluence Otherworld: Better Experience)
2. Put the Water Bucket in the Working Stove (Only one Water Bucket will also cause this issue)
3. Waiting for the salt.
4. Salt baked, but no bucket remains.

Expected behavior

The buckets should be returned.

Mod Version

1.0.12

Minecraft Version

1.21.1

Modloader

neoforge

Crash Log (if applicable)

No response

Additional context

No response

Yes, but the stove returns no bucket.

That is most likely a problem with the mods that are adding that functionality. In the code, an item will reference another item to be returned during crafting. If the item references no item, nothing is returned. Water bucket should return a normal bucket, but sounds like their mod is doing something else.

I can add a fallback, but this is not expected behaviour my mod or vanilla can handle. Buckets aren't stackable in vanilla. When recipes are designed around a known behaviour, and a mod modifies that behaviour (like removing the stack limit), it creates new problems that would never exist when I tested the mod.

For example, if I give myself a stackable lava bucket /give @s minecraft:lava_bucket[minecraft:max_stack_size=64] 64 and use it as fuel in a furnace, it will delete the entire stack with the bucket item.

I am not saying you can't install the mod, just expect potential problems with mods since they are tested against the vanilla game.

In my testing, the vanilla furnace will return at least one bucket🤔

It returns 1, but deletes the 63 other lava buckets.

I have tried again and am pretty sure that it's caused by the stove itself. The water buckets obtained from /give @s minecraft:water_bucket[minecraft:max_stack_size=64] 64 will cause no buckets return, while the normal water buckets can return buckets as expected.

Okay, so while I can match how vanilla works, the lava buckets are still deleted by the returned bucket.

That's just ok, or just allow one liquid bucket like the furnace fuel slot empty bucket behavior? you can only put one empty bucket there.