Doctor Who - Regeneration

Doctor Who - Regeneration

318k Downloads

[BUG] Some Entities Render Invisible on 1.12

WildBamaBoy opened this issue ยท 3 comments

commented

Describe the bug
A user of MCA reported that villagers are invisible, but it seems to go a bit deeper as a few other mobs are rendering invisible as well.

To Reproduce
Spawn a Skeleton to see an example. Console is spammed with errors.

Additional context
Looks like you're incorrectly assuming that you have an EntityPlayer while building an AnimationContext here: https://github.com/Suffril/Regeneration/blob/1.12/src/main/java/me/suff/regeneration/client/ClientEventHandler.java#L138

me.suff.regeneration.client.ClientEventHandler onAnimate(Lme/suff/regeneration/client/sound/echo/AnimationEvent$SetRotationAngles;)V
[17:41:29] [Client thread/ERROR] [minecraft/RenderLivingBase]: Couldn't render entity
java.lang.ClassCastException: net.minecraft.entity.monster.EntityZombie cannot be cast to net.minecraft.entity.player.EntityPlayer
	at me.suff.regeneration.client.ClientEventHandler.onAnimate(ClientEventHandler.java:138) ~[ClientEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_11_ClientEventHandler_onAnimate_SetRotationAngles.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) ~[EventBus.class:?]
	at me.suff.regeneration.client.sound.echo.RegenClassTransformer.renderBipedPre(RegenClassTransformer.java:88) ~[RegenClassTransformer.class:?]
	at net.minecraft.client.model.ModelBiped.func_78088_a(SourceFile:79) ~[bpx.class:?]
	at net.minecraft.client.renderer.entity.RenderLivingBase.func_77036_a(RenderLivingBase.java:250) ~[caa.class:?]
	at net.minecraft.client.renderer.entity.RenderLivingBase.func_76986_a(RenderLivingBase.java:175) [caa.class:?]
	at net.minecraft.client.renderer.entity.RenderLiving.func_76986_a(SourceFile:41) [caf.class:?]
	at net.minecraft.client.renderer.entity.RenderLiving.func_76986_a(SourceFile:16) [caf.class:?]
	at net.minecraft.client.renderer.entity.RenderManager.func_188391_a(RenderManager.java:384) [bzf.class:?]
	at net.minecraft.client.renderer.entity.RenderManager.func_188388_a(RenderManager.java:368) [bzf.class:?]
	at net.minecraft.client.renderer.RenderGlobal.func_180446_a(RenderGlobal.java:628) [buy.class:?]
	at net.minecraft.client.renderer.EntityRenderer.func_175068_a(EntityRenderer.java:1347) [buq.class:?]
	at net.minecraft.client.renderer.EntityRenderer.func_78471_a(EntityRenderer.java:1259) [buq.class:?]
	at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1062) [buq.class:?]
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1119) [bib.class:?]
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:398) [bib.class:?]
	at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_191]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_191]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]
commented

Don't know how that got past me, thanks for reporting it to me
Considering the nature of the bug, I'll have it fixed pretty quick
Sorry that the user had to experience this issue

commented

Did you fix this in bcc2afb?

commented

I did, forgot to close it