Doctor Who - Regeneration

Doctor Who - Regeneration

318k Downloads

[BUG]+[Suggestion] Various Lindos issues

Darkmega18 opened this issue ยท 13 comments

commented

Describe the bug
Lindos vial gives "mortal" players a free regen on use. But doesn't give it to already timelord people. Just consumes a regen like as if you had died normally. Which I'm guessing is a bug.

Lindos is also extremely touchy, and the slightest rightclick once it's full will kill you accidentally to trigger a regen, which might not have been on purpose, such as having it in the offhand when juggling lindos vials to charge during a regen.

PLEASE make the lindos have to be... drunk? Charged for a couple of seconds? held infront of you like focusing on it? something of the sort to identify it's doing something.

Same deal with the "kill yourself and regenerate" button. Have it produce an effect on screen over a 2 second period of needing to hold it, so people trying to press buttons who haven't mapped it somewhere else out of the way don't accidentally off themselves.

Lindos will also consume itself by accident if you try to use it or ACCIDENTALLY use it during post regen without doing anything, because post regeneration super resistance negates the damage required to put you back into the grace state to begin another regen.

Lindos's action also won't be canceled when trying to open a hand container gui with it in your hand by accident. I tried to open my hand container and I accidentally offed myself cause it triggered when opening a gui when checking my containers for residual energy. I also see the vial telling me it's not full yet when I open containers with a not quite full one, meaning it's trying to do something.

Also, is the residual energy stuff separate from lindos energy in a flask? Could there be a way to say, store that energy from a lindos and put it in hand container to energize it, then take that energy like you can for the free regen when it fills?

Like say, a container is like 3 regenerations with luck to fill, while a vial filled in one while holding it (plus a third of another one i've noticed when I dual wield and swap mid regen) what if putting the lindos into the jar will take the energy out of it, with a max flask giving it 33-35ish energy? Or would that break some balance-y line you didn't want crossed in the first place?

anyways, bug/suggestion/nitpick.

To Reproduce
Steps to reproduce the behavior:

  1. Get lindos. and fill it.
  2. Die. charge the flask. then fast forward regen/do whatever.
  3. Use it when normal. Notice you don't get your 1 regen back (to compensate for the energy you're using from the lindos to regenerate on command instead) that will be consumed and you instead eat into your total regens.
  4. Now, repeat, but instead, use it when you've got no regens to spare/converted them into the watch. You'll get a free regen just to use cause you triggered death via flask.
  5. wonder why you can't do that without having to go the long way around.

Expected behavior
Using the lindos to trigger regen without dieing gives a free regen for... corrective gene therapy on timelords or for mortals to heal etc.

commented

image
Before vial usage with regens.

image
used the vial that was full. No regen gained.

image

After Regen, I used one. :< I also synced to hand just as the next vial refilled.

just a mortal now.
image

got the free regen when using vial.
image

is this balanced so you can't just keep reusing vials? or is this intended, so you can like... regen, then share it with someone less fortunate...? I dunno. lemme know if this is how it's meant to go. :V

bonus!
image
sucking the energy out of a container after regenerating to get the free regen erases text. probably nothing you can do here. but just a tiny thing. atleast this way works.

commented

also, little item carrying rendering derpiness with the loped off hand in model.
image

maybe make it do the offhand so the main hand renders fine? since you've got the whole "off hand auto drops stuff" anyway, so it fits. although, unrelated to lindos, but discovered it while doing all this lindos testing and stuff and all the times I did the hand chop... Taking some damage from your own hand chop equal to the sword's own damage might also be worth something. even if it'll get nullified by post regen. Just a flinch or something, so it looks like it hurt, rather than just going "pop". :V

commented

I have begun to address some of these issues you have mentioned, please see the referenced commit to see what has been addressed so far.

Could I ask that you separate your issues up a bit more and also add headings to separate different topics? I struggle with large amounts of text from time to time and it's difficult to read what you're after/addressing due to it not being divided up into parts too well and being very long

Rendering bugs should be their own separate issue, although I appreciate you pointing this out

commented

Also, is the residual energy stuff separate from lindos energy in a flask? Could there be a way to say, store that energy from a lindos and put it in hand container to energize it, then take that energy like you can for the free regen when it fills?

It's the same thing, but currently, there is only a way to take energy out of those and into vials
https://github.com/Swirtzly/Regeneration/blob/c6778b6b84389b8ba9ab282724e7092efa174433/src/main/java/me/swirtzly/regeneration/common/item/ItemLindos.java#L157-L164

commented

Roger. sorry, I end up... ranting... wall of texting... etc when I get going. I'll try a little harder next time. :)

also, wait, so is a 100 jar MEANT to be equivalent to one lindos full? or do the jars just need a lot more energy before you can siphon it off for the freebie to keep later unlike the lindos which basically one shots you there and then?

commented

If you filled a kinda vial with water and proceeded to right click a jar while sneaking with say, 100 residual energy (I'm changing that word to lindos in the coming update)

You would have a vial, with 100 lindos, meaning that you could siphon it from the jar into a freebie

The jar and the vials were added months apart and no real consideration was taken into balancing it all, it needs a proper looking into, but I don't think anyone actually knows that you could do this because admittedly, I'm terrible at documenting things as I do them

commented

hah. well alrighty. So lindos vial energy and hand container energy is meant to be very similar. Just one is portable and instant, and one is stationary and lets you keep the energy.

Also, for that balance, and despite myself liking being able to do this:
I've been playing for a bit and I've managed to generate 2 watches full of regens starting from like 1 regen and a lindos vial and several hand containers.
when you regen it fills all of the containers in a wide area semi-randomly by about a quarter to a third, but I could cap around 1.5 lindos vials full with energy during a single regen.

So I'd basically just reuse the regen in the vial after it decayed, grab the little bonus lindos particle in another flask. Then proceed to put a hand in the containers. I would then finish post regen, and then lindos again and keep repeating, and the containers would eventually fill and I'd harvest the regens out of them and keep going. Eventually having several vials.

If you had no regens, I'd still get the free one while mortal even while in post regen. so if I managed to fill multiple lindos, I'd eat a lindos while post, and not die, gaining 1, which when post was over, I'd put into the clock, then down a spare lindos yet again and keep going, eventually filling up several watches by looping it over and over. :V

so, a touch on the busted side, by anyone elses account. Fair and balanced cause it takes some time in my account to keep looping and in my pack theres lots of watches in loot boxes lying around during serious play.

This was just being done in a test world. :P

commented

By watched do you mean watches?

commented

yeah, whoops.

commented

How goes things? will the update for these bugs etc be in a 1.12.2 version, or are you looking to carry onto the more modern minecrafts already?

commented

Hello? Will these fixes etc be made available? I haven't heard anything in a while, so just checking up. Since I'm still sitting on the version with the sync fix you gave me some time ago which isn't an officially available version that can be picked up by curse when it comes to sending the pack to others.

commented

I'm very busy in real life these past few weeks, progress has been slow, but these issues are fixed, but I must finish a different new feature before I release these fixes, this will most likely be the last version for 1.12 (bug fixes aside) and I want to get everything I wanted in, in, I'm just having difficulties with item containers, but after that, it'll be fine

commented

I guess the chameleon Arch. :o getting close to that episode in my watchings of the modern doctor who. found out about it cause of the sound effect you use on the fob watch actually...

and well, I hope you the best with the life stuff, and smooth sailing once you can make progress. :)