Possible Incompat with TieredZ - Can't use smithing table to apply Relic to tiered modded item
jmadarg opened this issue · 12 comments
MC version: 1.19.2 Fabric
Modpack: Medieval MC [FABRIC] - MMC1
Problem: When trying to ass a Relic to a modded item that has a tier (TieredZ mod adds tiers to the items like armor/tools/weapons) , the Relic does not add any property. It works fine if the item is vanilla and has a tier, or if the item doesn't have a tier (modded or vanilla). Not always happens, I'm still not able to pinpoint exactly what triggers the problem.
Modded item without any tier:
Modded item with a tier but not working properly:
Modded item with a tier but working properly (was a different set of properties on the tier and a different Relic):
I opened an issue on the TieredZ github too Globox1997/tiered#43
I also wanted to add that you can't join a vanilla armor already found enchanted (e.g.: found in a dungeon chest and the likes) and a relic in the same way: the vanilla armor doesn't get the stats even if the action is possible. Screenshots attached.
Hi there @jmadarg @Yasamashi @Totitodios
I appreciate the detailed report; I'll look into it.
Thanks.
Hello, I’d just like to add some clarity here, as I believe there are two separate issues:
@jmadarg ’s example is likely only visual - equipping the item will still apply the relic’s stats to the player even if they aren’t visible. This is likely an issue with tieredZ or a limit with item descriptions as this interaction happens with many other mods. I also feel it’s a fairly minor issue.
However, the examples from @Totitodios and @Yasamashi are different - the items with relics being applied are likely being affected by Dungeon Difficulty, which applies bonuses to looted items, as these screenshots seem to be from Medieval MC Fabric after that mod was added to the pack, and they specify that these items are from a chest (while the Heavy armor from jmadarg’s example was crafting-only at the time)
When a Dungeon Difficulty enhanced item has a relic affixed, it not only does not show its bonuses, but does not apply to the player, as @Yasamashi shows.
I haven’t yet checked if the NBT from the relic still applies to the new item in the case of the Dungeon Difficulty issue.
I’m using the latest update from yesterday, unfortunately this appears unrelated to that fix. It happens both before and after this version
Just double checked - in the case of Dungeon Difficulty, the NBT does apply, but the bonuses do not, when equipped.
Here's the item I checked -
The TieredZ stats don't apply either, but that's also present only with Dungeon Difficulty bonuses. I don't know the first thing about these implementations, but it appears Dungeon DIfficulty's AttributeModifiers is interfering with both of these mods.
If this isn't something that can be resolved, I might suggest making the relic smithing table recipe incompatible with anything with the AttributeModifiers nbt.
Just to provide update on this: I have identified exactly what is happening, and have a couple of routes towards a fix. Hopefully will include this in next release - no exact timeframe as of yet.
Latest release 3.3.1-1.18.2 and 3.3.1-1.19.2 fixes this issue and is available now on Modrinth, pending approval on Curseforge.
@CleverNucleus how did you resolve this incompatibility with dungeons difficulty?
how did you resolve this incompatibility with dungeons difficulty?
@Globox1997, it is not yet resolved for Dungeon Difficulty, only TieredZ. There is a separate issue for this here.