[1.12.2] Interdiction Torch blacklist causes server lag and doesn't work
flamechair opened this issue ยท 1 comments
Forge: forge-1.12.2-14.23.1.2555-universal-server
Minecraft: 1.12.2
SpongeForge: spongeforge-1.12.2-2555-7.1.0-BETA-2842
Config:
##########################################################################################################
# interdiction_torch
#--------------------------------------------------------------------------------------------------------#
# Interdiction Torch settings
##########################################################################################################
interdiction_torch {
# Whether the torch can push projectiles
B:can_push_projectiles=false
# Radius in which the torch can push out mobs
# Min: 1
# Max: 15
I:push_radius=8
# List of entities that are banned from being pushed by the torch
S:pushable_entities_blacklist <
minecraft:horse
minecraft:llama
minecraft:cow
minecraft:polar_bear
minecraft:chicken
minecraft:rabbit
minecraft:ocelot
minecraft:parrot
minecraft:pig
minecraft:sheep
minecraft:squid
minecraft:bat
minecraft:wolf
minecraft:mule
minecraft:mooshroom
minecraft:donkey
minecraft:villager
minecraft:elder_guardian
twilightforest:wild_boar
twilightforest:deer
twilightforest:bunny
twilightforest:penguin
twilightforest:bighorn_sheep
twilightforest:squirrel
twilightforest:raven
twilightforest:tower_boss
twilightforest:naga
twilightforest:naga_segment
twilightforest:lich
twilightforest:quest_ram
twilightforest:hydra
twilightforest:hydra_head
twilightforest:ur_ghast
twilightforest:yeti_alpha
twilightforest:snow_queen
twilightforest:giant_miner
twilightforest:armored_giant
twilightforest:minotaur
sophisticatedwolves:textures/entity/brown/wolf.png
sophisticatedwolves:textures/entity/black/wolf.png
sophisticatedwolves:textures/entity/forest/wolf.png
sophisticatedwolves:textures/entity/gray/wolf.png
nex:boss_ghast_queen
>
# List of projectiles that are banned from being pushed by the torch
S:pushable_projectiles_blacklist <
>
}
No errors in the log, and with the blacklist as it is above it generates variations of this:
> [06:10:21] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 31897ms behind, skipping 637 tick(s)
> [06:10:33] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 11806ms behind, skipping 236 tick(s)
> [06:11:04] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 23739ms behind, skipping 474 tick(s)
> [06:11:12] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 7588ms behind, skipping 151 tick(s)
> [06:11:54] [Server thread/INFO] [nucleus]: defkult ran the command: /home
> [06:12:42] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 54447ms behind, skipping 1088 tick(s)
> [06:12:46] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 3721ms behind, skipping 74 tick(s)
> [06:13:08] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 9096ms behind, skipping 181 tick(s)
> [06:13:27] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 8220ms behind, skipping 164 tick(s)
> [06:13:40] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 4661ms behind, skipping 93 tick(s)
> [06:14:03] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 6866ms behind, skipping 137 tick(s)
> [06:14:21] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 6173ms behind, skipping 123 tick(s)
> [06:14:51] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 13765ms behind, skipping 275 tick(s)
> [06:14:57] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 3767ms behind, skipping 75 tick(s)
This is on a fresh restart, about a minute after it finished booting up. I logged in and tested the mobs in the blacklist above, and it still pushes the mobs away. After removing the entities from the blacklist and rebooting, the server lag goes away.
I have fixed the interdiction torch blacklist and have moved code around a little for a little better performance, but I am a little sceptical that the blacklist was causing this for you unless you had hundreds of entities very close to the interdiction torch and even then it probably wouldn't be any issue at all.
With your blacklist I had almost no issues on a slow old laptop upon spawning about 100 horses in a close proximity to the torch and even then I would guess the slowdown was more about entities themselves causing lag than the blacklist querying.
Anyway it's released on curseforge, please test and feel free to log a new issue if you're still seeing any performance issues.