Replay Mod (Fabric & Forge)

Replay Mod (Fabric & Forge)

787k Downloads

Missing map art in video render

Opened this issue ยท 12 comments

commented

Hello. I noticed map art is not rendered while in spectate mode from the Replay Mod. When you look at a map, it is blank. This is really unfortunate for me, and I'm wondering if there's a way to fix this. I would have liked to ask on the forums, but it appears I'm able able to register there for some reason. The registration button is nowhere to be found.
blank-map

commented

Which Minecraft and ReplayMod versions were you using?

commented

Also a side-issue I will bring to your attention. Using the most recent Fabric API (fabric-api-0.4.3+build.247-1.14.jar) causes text GUI problems. I downgraded to the Fabric API version above, and the text displays fine again.
Screenshot_2020-03-23_20-48-14
Aside from the Fabric API, I believe I'm using the most up-to-date versions.

commented

The text issue is a known one, see #101 for workarounds.

commented

Is there a workaround for the map not rendering? Such as using an older version of Replay Mod? I'm surprised nobody has made you aware of it.

commented

None that I know of. This is the first time I hear about it (may be that it just appear with the 1.14 version).
Tbh I wouldn't even know of the top of my head how it could break like that. Someone will have to take a close look at it. However since I'm currently not actively working on the RM, it might be some time before that happens.

commented

Okay no worries. Thanks for the response.

commented

I am using replaymod-1.14.4-2.2.0-b7 on fabric-loader-0.7.8+build.184-1.14.4, with fabric-api-0.4.1+build.245-1.14.jar in the mod folder.

commented

For clarification, the map art does not appear in the Replay Mod editor also, so it's not a video rendering problem.

commented

Are you spectating the player that recorded the replay? The server only sends map data if the map is in an item frame or to the player that is holding a map. And the replay mod can obviously only record what the client receives.

commented

I recorded myself playing the game occasionally looking at map art I was holding, and in the Replay Editor went to spectate myself and then rendered it. I didn't notice in the Replay Editor that the map art was blank, only after rendering the video. The map art was present in the game of course, just not in the Editor.

See the video here: https://youtu.be/ned8JP5n-n0?t=44

commented

Upon close inspection, this appears to be a bug in the Start/Stop/Pause/Resume recording feature. To reproduce it, I need to make use of that feature during recording at least once.
So one can work around the issue by not using that feature.

The code implementing that feature has been completely re-written in the process of updating to 1.15 because it contained various fundamental flaws. I can no longer reproduce the issue with the new version (a 1.14.4 RM jar built from the 1.15 branch), so whatever the issue was, it probably got fixed as a side-effect of that re-write.
I'll close this issue once the new version gets a proper release.

commented

Thank you, that solution does the trick.