Replay Mod (Fabric & Forge)

Replay Mod (Fabric & Forge)

787k Downloads

Replay Viewer button is drawn unexpectedly on another mod's confirmation screen

BLOKBUSTR opened this issue ยท 1 comments

commented

I recently installed RedstoneTools, and I already had this mod installed prior. On the first startup with RedstoneTools present, it shows a confirmation prompt, which then leads to the main menu once you select an option. Here the Replay Viewer button appears unexpectedly and intrusively.

2023-06-05_18 38 10

I created an issue on their end first which provides more context on the behavior of this issue, however it does go slightly off-topic: RedstoneTools/redstonetools-mod#245

Off-Topic Details: Once I open a replay, the issue isn't specifically related to the main menu button anymore, but rather an issue with client rendering, possibly with Blur influencing this. The screen only showed a single color at a time which changed as I looked around or moved. All the UI elements were correctly rendered though, and I only experienced this once.

One of RedstoneTools' devs suggested that this mod should check whether or not the Replay Viewer button is allowed to be drawn, such as on confirmation screens. They mentioned that this mod already checks specifically for CustomMainMenu, but doesn't have exceptions for any other mod.

It also just occurred to me that Create has its own similar menu button, and I have not encountered it on RedstoneTools' confirmation screen. Perhaps its own code could provide some insight.

commented

Duplicate of #621