Repurposed Structures (Fabric/Quilt)

Repurposed Structures (Fabric/Quilt)

20M Downloads

NullPointerException ... because "pair" is null on NeoForge 1.21.1

mpustovoi opened this issue ยท 5 comments

commented

That's not the first time I see that issue on my test world:

[Server thread/ERROR] [net.minecraft.util.thread.BlockableEventLoop/FATAL]: Error executing task on Server
java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke "com.mojang.datafixers.util.Pair.getFirst()" because "pair" is null
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) ~[?:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.TickTask.run(TickTask.java:18) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:872) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:170) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:855) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:849) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:821) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:826) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:712) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:267) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "com.mojang.datafixers.util.Pair.getFirst()" because "pair" is null
	at TRANSFORMER/[email protected]+1.21.1-neoforge/com.telepathicgrunt.repurposedstructures.misc.maptrades.MerchantMapUpdating.lambda$updateMapAsync$5(MerchantMapUpdating.java:131) ~[repurposed_structures-7.5.13+1.21.1-neoforge.jar%23801!/:?]
	at TRANSFORMER/[email protected]+1.21.1-neoforge/com.telepathicgrunt.repurposedstructures.utils.AsyncLocator$LocateTask.lambda$thenOnServerThread$0(AsyncLocator.java:147) ~[repurposed_structures-7.5.13+1.21.1-neoforge.jar%23801!/:?]
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:60) ~[client-1.21.1-20240808.144430-srg.jar%23541!/:?]
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
	... 14 more

Full logs: https://mclo.gs/EQPm1rO.

It generally appears either when I join the world or at the random moment some time after.
Although, it doesn't lead to a crash or anything, I just wonder if it's critical.

My only guess to errors with data fixer (as far as I understand what it is) can be addressed to Tectonic mod, which was reworked quite recently and is expected to have some issues, which I didn't encounter, I guess.

I also have the compat packs for the respective mods:
Image

Previously I had issues with Visible Traders mod that was freezing the internal server for 15 long minutes due to some trader maps issues, but I removed it a long time ago and thi test world was newly created without it.

commented

resolved now with new version released

commented

Did you remove any RS structures from spawning?

commented

No, I didn't even touch the config or compat data packs I have.

commented

I just created three new world, flew around for some time and teleported to random RS structures via /locate and didn't see the same error neither when joining the world nor some time after.
So I consider it's just with the test world. Maybe some mod updates did something to it. Last time it was created was about two weeks ago.

commented

No it is the Wandering Trader map crashing because the structure it was trying to find was too far away and so, the locating method returned null for no result and crashed my code. I will fix it