Repurposed Structures (Forge)

Me again!

This is the same suggestion as the I made in this thread #40

Basically, let RS create its mineshaft variants, but with Yung's Better Mineshafts design

Better Mineshafts CurseForge: https://www.curseforge.com/minecraft/mc-mods/yungs-better-mineshafts-forge

Ah. That would be a better suggestion for Yung's as my mineshafts are suppose to be vanilla based. To do yung style Mineshafts, I would just end up copying his mod entirely which I rather not do (copying mods exactly is very frowned upon in modding). And would break the purpose of my mod.

However, he can easily add variants on his end though. Try and suggest this to him as he might like the idea! I can go ask him if you want me to.

I would be grateful if you do it as it'll take me half an hour to explain what I mean hahaha

RS should already support allowing it's mineshafts spawning alongside yung's. Are you able to find both in a world?

Basically, I got code to detect if yung's is on and to not remove the vanilla mineshaft if so which allows them to replace it. (I always add my mineshafts no matter what)

RepurposedStructures/src/main/java/com/telepathicgrunt/repurposedstructures/RSAddFeaturesAndStructures.java

Lines 97 to 99 in 7adf4a1

    
           if (RepurposedStructures.yungsBetterMineshaftIsNotOn){ 
        
               event.getGeneration().getStructures().removeIf((supplier) -> supplier.get().feature == Structure.MINESHAFT); 
        
           }

My English isn't the best so apologies if I wasn't clear with what I said.

Both Yung's and RS mineshafts spawn. My suggestion is this, instead of RS creating mineshafts that follow the vanilla mineshaft design, let it use Yung's mineshaft design.

As you can see on the first picture, this is a standard Yung's mineshaft. On the second is a RS jungle mineshaft. My idea suggests for RS to create a mineshaft that uses Yung's design instead of the vanilla one. So all the oak planks, fences etc. in the first picture would be replaces with their jungle counterparts. Hopefully that makes sense. Again, apologies for my English!

Done. I just let him know now!

Turns out, the Better Mineshaft dev already has 9 biome variants of his Mineshafts. Try exploring a bit and you might find them! I didn't know he had variants already but that is pretty neat

edit: there's actually some pictures of his mineshaft variations on his curseforge page here https://www.curseforge.com/minecraft/mc-mods/yungs-better-mineshafts-forge/screenshots

	if (RepurposedStructures.yungsBetterMineshaftIsNotOn){
	event.getGeneration().getStructures().removeIf((supplier) -> supplier.get().feature == Structure.MINESHAFT);
	}

Share to