Repurposed Structures (Neoforge/Forge)

Repurposed Structures (Neoforge/Forge)

58M Downloads

Unable to localize via resourcepack

ChromaPIE opened this issue ยท 6 comments

commented

As has been described from the title, Repurposed Structures seems unable to load (or show) localized texts in the resourcepack. Tested with a self-made resourcepack containing a zh_cn.json (Simplified Chinese) and I'm sure that it's a valid JSON file and has been put under a correct directory. but after several reboots and reloads the localization still couldn't take any effect. By the way it worths a notice that my JSON has been formatted.

commented

This is about the advancements correct? Did you put on this resourcepack as well?
https://github.com/TelepathicGrunt/RepurposedStructures-Fabric/releases/tag/0.0.8

Basically, repurposed structures ships with advancements already containing english text so that people on servers do not need clients to require a resource pack for translations. But with the resourcepack above, this will force the advancments to now use translation keys and thus, your zh_cn.json file will take effect.

If you're alright with sharing the zh_cn.json file, may I see it as well? I could also package it with the Translation Advancement pack as well that is on my mod's curseforge page
image

commented

zh_cn.zip

JSON is not supported for attachment so I zipped it. Seriously translated it even it's intended for personal usage, and I'll be appreciated if it's officially packed.

commented

ALSO PLEASE NOTICE that in quite a lot of the JSONs in the RSTA datapack, the objects after which the localization keys of the titles and description texts were defined, were wrongly named after "text", making the advancements showing bare keys for titles and descs. Editting it to "translate" fixes the problem, and this should be fixed officially too.

commented

Oh crap. The new structure's had "text" instead of "translate". nice catch lol.
And thank you so much! I'll update that datapack to have your translations and fix the other json files

commented

ALLLSO LOL, caught another bug, a duplicated advancement
image
image

And probably the last problem, check the outpost_birch.json and cities.json, there wrote the original texts, but not the localization keys.

commented

you're on a roll lol! datapack is now updated with all those fixes