Repurposed Structures (Neoforge/Forge)

Repurposed Structures (Neoforge/Forge)

57M Downloads

Some structures have incorrect materials

Brun333rp opened this issue ยท 6 comments

commented

While i was testing the mod, I noticed that some structures use inconsistent materials, materials that are part of their original counterparts or are not correctly distributed. Here are the ones I found so far:

Desert Mansions:

Desert Mansions have Dark Oak related blocks
2021-04-02_22 30 25

2021-04-02_22 31 06

2021-04-02_22 31 32

2021-04-02_22 32 32

2021-04-02_22 32 43

2021-04-02_22 32 54

2021-04-02_22 35 06

Solution: Replace them with Jungle or Birch blocks


Birch Mansion

Birch Mansions have Oak related blocks

2021-04-02_22 38 04

2021-04-02_22 38 19

2021-04-02_22 38 47

2021-04-02_22 39 01

Solution: Replace them with Birch blocks. Oak blocks next to Bookshelves should be kept though.

Also, I found this illager statue that was incomplete. Idk if this is something related with the mansion itself or caused by terrain generation. Note that part of the floor next to it was incomplete as well
2021-04-02_22 41 16


Oak Mansion

  1. Entrance and staircase to the second floor use Red Carpets.

2021-04-02_22 55 43

2021-04-02_22 56 01

Solution: Replace them with Brown Carpets

  1. Bookshelves have Spruce blocks next to them, wich looks weird.

2021-04-02_22 56 27

2021-04-02_22 57 41

Solution: replace them with Oak blocks. But only those that are connected to the bookshelves.


Savanna Mansion

  1. Some rooms use a Dark Oak floor.

2021-04-02_23 05 22

Solution: Replace the floor with Oak blocks

  1. Cobblestone Stairs and Slabs are replaced with Dark Oak ones.

2021-04-02_23 05 12

2021-04-02_23 08 13

2021-04-02_23 08 03

2021-04-02_23 06 47

Solution: Replace them back to Cobblestone


Snowy Mansion

  1. Some parts of the mansion use Ice blocks alongside Diorite Stairs and Slabs, wich looks weird.

2021-04-02_23 14 41

2021-04-02_23 16 36

2021-04-02_23 17 52

2021-04-02_23 21 37

2021-04-02_23 32 33

2021-04-02_23 33 08

Solution: Replace these specific parts with Diorite and Polished Diorite. But only those that are next to stairs, slabs and bookshelves.

  1. Some rooms use Dark Oak on them.

2021-04-02_23 11 47

2021-04-02_23 24 18

Solution: Replace the floor with Packed ice, just like the rest of the mansion. The fences should either be replaced with Spruce ones, or have a different design, like this:
2021-04-02_23 27 40

  1. Cobblestone is still present in some rooms, wich can also be seen previously.

2021-04-03_15 21 33

Solution: replace the Cobblestone with Diorite and Polished Diorite. And considering the first item, you should also replace most of the ice on this room as well.

OBS: This room also uses a Dark Oak floor.

2021-04-03_15 24 40


Taiga Mansion

Birch stairs, slabs and fences are present in some rooms.

2021-04-03_16 09 10

2021-04-03_16 30 24

Solution: Replace them with Cobblestone, though these that are part of chairs and tables should be replaced with Andesite.

Also, not exactly a bug, but I bet this statue is supposed to be a fox. But it looks more like a cat than a fox.

2021-04-02_23 41 11


Well, these are the ones I discovered so far. If I forgot something, I'm sorry.

commented

Fun fact, vanilla mansions actually uses multiple wood types. They use dark oak, oak, birch wood. Many of the mansion pieces you shown here was my direct 1-to-1 replacements working as intended. Although some can be made better to fit their theme which means they will become no longer similar to vanilla mansion's placements.

Gonna try and go through everything you listed:

Desert Mansions dark oak should be sandstone wall except for the cage. Sandstone walls looks terrible as you cannot see inside the cage so I'll only be replacing the dark oak fences that hold up torches and stuff. Cages and that fence room will remain dark oak fences. The dark oak door will remain dark oak unless jungle/acacia door looks better. I'll have to place it down in person to see.

Birch Mansion's oak blocks will remain as oak blocks. When converting the vanilla mansion to birch mansion, I turned their Birch wood to Oak wood and then turned their Dark Oak wood to Birch wood. So the birch mansion is actually correct and has the multiple wood type in the right places to match vanilla mansions. The incomplete floor/wall thing you found is a bug with how mansions generates in general. In fact, take a closer look at vanilla mansions. Sometimes you may find holes between the second and third floor that leads outside the mansion. It's wacky lol.

Oak Mansion's entrance carpet... oops. yeah I gotta fix that. The bookshelf part is a good catch and I'll make those be oak wood since the 1-to-1 replacement for that wood didn't work out nicely in the end for the bookshelves.

Savanna Mansion's dark oak wood was intended to replace cobblestone stairs and stuff to try and fit better. But I guess it didn't work out so I'll bite the bullet and revert those back to cobblestone.

Snowy Mansion's diorite with ice, I thought it looked good but guess now. I'll mess with that and see if full diorite looks better. The Dark Oak wood will remain as they are necessary for gates and cage fences.

Taiga Mansion's birch wood will remain to match vanilla mansion's multiple wood usage. And about the fox, oof. I tried my best but I cannot make a better statue. That was the best I can do so it has to stay as is for now unless someone sends me an nbt file of a better tiny fox statue.

Thank you for your report! I'll be going though the nbt pieces to work on some of these stuff

commented

Oh actually about that pillager face wall, that looks to be intended. Dig inside for the actual room. one of the wall is that face and it can show bare like so. Vanilla piece picture:
image

commented

Cages and that fence room will remain dark oak fences.

Well, you know that there are other fitting materials for this, right? These should be either Jungle to fit with desert villages (since they use Jungle wood in certain parts) or Birch to fit with sandstone (similar with how you did with desert outposts).

Taiga Mansion's birch wood will remain to match vanilla mansion's multiple wood usage.

But as you can see, in some parts there's a mix of Cobblestone and Birch, wich looks weird. As it seems, Cobblestone was meant to replace Birch Planks, since the floor uses Cobblestone. So I assumed that you forgot to replace Birch Slabs, Stairs and Walls with Cobblestone ones.

The Dark Oak wood will remain as they are necessary for gates and cage fences.

Spruce wood is a alternative. Dark Oak would not look bad, but Spruce makes more sense with the icy theme of the building.

commented
  1. The stairway is perfectly fine and isnt suppose to be cobblestone at the top. hence the birch stairs. The arch thing was changed to be fully birch. I did change that arch in several of the other mansions to be one type of block as it seemed the script replacement didnt work so well for that particular piece.

1 and 3) I actually like the darkness of the dark oak wood against the light ice and sandstone. Testing with other wood types feels too light and loses that slight illager feel. I'm not entirely sold on making them not dark oak. Especially as mojang seems to be ok with outposts using dark oak in any biome it is in so illagers have access to dark oak everywhere. In fact, I probably should be using more more dark oak as that's a signature wood type for illagers. hmm

commented

Ah i see what you mean about the stairs. That piece I was suppose to do by hand since the floor was made to be cobblestone but shouldnt be cobblestone on the stair part. I'll change that to either oak, spruce, or dark oak wood to look better depending on which fits best. but it seems the taiga mansion is spruce, oak, birch mix. Maybe I should've gone with oak for the stairway. Or maybe I should turn all birch to dark oak

commented

Big update to repurposed structures is now released! I squeezed in a bunch of suggestions form here into it