Requiem - Pandemonium Expansion

Requiem - Pandemonium Expansion

55k Downloads

PlayerRevive incompatibility

CreativeMD opened this issue ยท 4 comments

commented

Hey there,
I'm the author of PlayerRevive, a mod which prevents death, instead the player will be knocked down. A timer will start, within this time the player can be revived otherwise he/ she will die. Unfortunately there seems to be an issue with Dissolution, someone reported it recently (CreativeMD/PlayerRevive#21). I'm confused by the crash-report as it crash during iterating all players (source).

Maybe you have an idea how to make both mods compatible?

In Regards
CreativeMD

commented

I also got that issue reported, but I don't really know what happens. It only occurs when the option to skip the death screen is enabled, so the issue is probably in this code, mostly copypasted from vanilla. I would guess there is some weirdness involved with vanilla not handling properly players respawning in the same tick.

commented

My pleasure to help squashing this bug

commented

Ok, I will test if catching the exception will fix the issue.

commented

Never mind I found an even better way to fix it. I just use the PlayerTickEvent instead (no idea why I was not using it in the first place). I'm pretty sure it should be fixed now. Thanks for your help!