Rereskillable Rereforked

Rereskillable Rereforked

166k Downloads

Epic Fight Mod Compatibility

megagnarxd opened this issue ยท 15 comments

commented
  1. Use EXP instead of levels like how it was implemented in reskillable instead of rereskillable
  2. Please allow compatibility between this mod and epic fight mod.

Thank you very much :D

commented

I've implemented the option to change the usage of xp, the new version will be on curseforge soon!

commented

very nice. Thank you very much

commented

Doesn't work if you do /experience add levels. But that's fine. Good work

commented

What do you mean by that exactly?

commented

/experience add levels
the command, doesn't work. But otherwise, it's all good. Thank you for making this happen

commented

I don't understand exactly what you mean when you say it doesn't work. Do you mean using the command doesn't give you levels?

commented

No, /experience command does give level. However, you can't use said experience to level up your reskillable skills

commented

Hmm, I'll look into that, not sure why that is.

commented

Maybe instead of having all levels drop back to zero, only a couple levels will be reduced by a small random amount after every death? Much like the first reskillable?

commented

Dear god what are the github servers doing...

commented

Anyway, can you elaborate on what you mean by "compatibility between this mod and epic fight mod"? Also, I don't know exactly how Reskillable works in that regard, I assume it uses xp points instead of levels?

commented

I've never coded so bear with me. I will try to explain it to the best of my abilities.

Yes, the original reskillable used experience points instead of levels. So when you are level 30 and leveling up a level 3 skill, you will not go from 30-3=27.

Epic fight mod uses a different attacking type. I have no idea how it works but I'm assuming reskillable register a hit as left clicking. Projectmmo, however, is able to stop all of epic fight's attacks. You may want to look into projectmmo's code and see how they do it. Thank you

commented

I don't know whether I want the mod to work like that with xp, but I'll consider adding that as a config option. As for the mod compatibility, I don't know whether I want to work on these kinds of features.

commented

I've decided to start implementing the XP usage change, but I won't be implementing this mod compat. Anyone willing to put in the work can submit a pull request however.

commented

I'll reopen your previous issue, this issue is just poorly named and not for all feature suggestions.