Resizing Potion

Resizing Potion

646k Downloads

[1.12.2] Having Resizing Potion installed breaks 'Step Assist' in some mods.

SonicX8000 opened this issue ยท 7 comments

commented

Minecraft: 1.12.2
Forge: 14.23.5.2824

Mods: 6
ArtemisLib-1.12.2-v1.0.4
conarm-1.12.2-1.2.3
Mantle-1.12-1.3.3.49
ProjectE-1.12.2-PE1.4.0
Resizing+Potion-r2.1
TConstruct-1.12.2-2.12.0.135


Step Assist in some mods allows you to walk up a full block instead of it being a half block. For some reason... having Resizing Potion installed breaks some forms of the Step Assist.

The Gem Boots from ProjectE and some Construct's Armory Boots with the "High Stride" modifier has Step Assist which should let you walk up full blocks... only... you're unable to for some reason.

'Gem Boots' let's you walk up 1 Block, 'High Stride' let's you walk up 1 1/2 Blocks and 'High Stride II' let's you walk up 2 1/2 Blocks.

Removing Resizing Potion will allow both those items to work as intended which means I can walk up the blocks.

commented

I think I know the problem. I'll get to fixing it soon

commented

Issue still exists in "resizingpotion-2.1.1" where the Step Assist from Construct's Armory & ProjectE's Gem Boots are still borked.

Other mods:
ArtemisLib-1.12.2-v1.0.4
conarm-1.12.2-1.2.3.4
Mantle-1.12-1.3.3.55
ProjectE-1.12.2-PE1.4.1
TConstruct-1.12.2-2.12.0.135

commented

Confirming this with FTB: Interactions. The offending line is https://github.com/CammiePone/Resize-Potion/blob/master/src/main/java/com/camellias/resizer/handlers/PotionHandler.java#L71

I'd suggest adding step height and storing that with an NBT tag on the player. That way you know how much to remove, rather than simply setting it

commented

What's your definition of "soon"?

commented

any update on this? We really love the mod but this is breaking for alot people using our pack.

commented

The latest version (currently pending on curseforge) should partially fix this.
Due to how step assist works, it might be necessary to re-apply all step assist mechanics after a size change (eg: remove and re-equip botania's sash, or ProjectE boots). I didn't actually test this because of my time schedule, so any feedback is appreciated, both on whether this fix works and whether re-equipping is necessary

commented

awesome, thanks for the quick reply!