Reskillable

Reskillable

20M Downloads

Incompatibility with Chococraft.

SlayerTheChikken opened this issue ยท 4 comments

commented

TeamChikken/ChocoCraft3-CHKNFork-1.12.2#27

Not sure who is to blame :P

commented

Ok I have some theories as to what may be causing it. I think on reskillable's end it is this line not the one linked in the crash report (due to the older version). And then for chococraft it goes to this line Given what could be throwing a null pointer at that point, my guess is that breedInfo is somehow null, so that calling serialize is throwing a null pointer. Given I see you are the dev of that, could you do a check when you get a chance to see if it still crashes if you add a an if statement around the setTag of

if (this.breedInfo != null) {
nbt.setTag(NBTKEY_BREEDINFO, this.breedInfo.serialize());
}

and see if it still crashes. (I mainly don't feel like having to create a local branch of Chococraft given it isn't just an end user reporting it.)

commented

I will look into it a bit later, but has this been tested with the latest version of reskillable? The crash report has version 1.10.0, and the latest version is 1.12.5. I don't think anything has changed about the right clicking block code since then, but I could be wrong. (The line numbers at the very least might have changed.

commented

I'm testing this fix right now, I also added the check in a few other places to be sure.
Edit: Seems to be fixed, I'll do some more testing to make sure, and then report back here. If everything is A OK then you can close the issue if you want.

commented

Should be solved now TeamChikken/ChocoCraft3-CHKNFork-1.12.2@ab005fb
No negative consequences during testing.