Other modders keep built-in packs in a folder within their mod called resourcepacks. You keep them in a folder called shipped. The former adds the packs only to the in-game resourcepacks list, which is good. Your method instead creates the resourcepack locally on the user's PC.

I find your method a bit of a problem. I'm a neat freak, so when mods have built-in packs I use, I remove them from the mod, and throw them in the config folder for Paxi to force load them on boot. If I don't use it, I delete it. That's where your way of shipping the packs becomes an issue, as removing the shipped folder from the mod causes the game to crash on boot.

I suggest repackaging the optional packs into a resourcepacks folder contained within the mod like other mods do, so they can be safely deleted if the user wills it.

I will have a look into it and update it as soon as possible, thanks for the suggestion.

Also can you provide an example of another Mod that has shipped resourcepacks?

Also can you provide an example of another Mod that has shipped resourcepacks?

Sorry for the late response. I had gone to bed shortly before you posted. I assume you're asking so you have an example to go off of. The images below shows how it's done with Continuity, but it's the same for all mods. I'll post a link to several mods that do this just in case.

https://modrinth.com/mod/continuity/version/3.0.0-beta.5+1.21
https://modrinth.com/mod/physicsmod/version/9hVF9EMT
https://modrinth.com/mod/eating-animation/version/1.9.71

They put the resourcepacks folder in the same place you placed your shipped folder. Also, resourcepacks bundled with mods in this way don't need to be zipped.

Ahh ok, found everything i need, i think i can release a new version tomorrow. Thanks for your Suggestion and help.

You're welcome, and thank you as well.