Detect bees which require wither roses and automatically apply wither trait
Grath opened this issue · 6 comments
Is your feature request related to a problem? Please describe.
Netherite bees used to kill themselves on wither roses, which was fixed in the default configurations. Enigmatica 6 just added Obsidian bees which require wither roses, and forgot to include the Wither trait so they're killing themselves on wither roses.
Describe the solution you'd like
Add the Wither trait automatically if a bee is configured to require wither roses.
Describe alternatives you've considered
Tie wither rose immunity to bees being required to use wither roses? I don't know which would be easier. I doubt that any pack dev would legitimately like to add suicidal bees, so it seems like this is something ripe for adding a fail-safe.
I’m not sure if this will actually happen tbh. Only bc there could be other flowers/blocks that do something similar and we wouldn’t know. Think of something like uranium and radiation poisoning
It doesn't fix all of the potential issues of special trait requirements/special flowers, but it's a potentially common issue ("well, this is a more valuable nether-adjacent bee, let's make it use wither roses!") that impacted the same pack twice in a row which, when I work in QA testing, raises a red flag of something that's unintuitive and could use some safety railings.
What Epic said a bunch of mods add things that give off a negative effect when near or touched so this wouldn't really work for all cases.
Also, we would have to check this every single time the bee wants to find a flower as the wither flower can be in a tag and tags can change on /reload or in different worlds so a check for if flower = "minecraft:wither_rose" wouldn't work properly and could cause performance issues as it would have to look up the tag of the flower and see if it has a wither rose.
Also checking for small edge cases that can be avoided if the pack dev adds a trait to the bee by either making their own trait using our custom trait system or using one of our default traits, this edge case what we would have to check for would just add bloat to the mod that is unneeded and would remove a "customization" too a bee even tho I highly doubt many devs would want a bee to use a wither flower and it also is able to die from it they can.
I respectfully disagree on "other mods might add hazards that get used for bees" being the same level of likely to cause problems as "a vanilla flower that's available in every Minecraft version supported by this mod"
Fair enough on the code complexity/performance concerns vs pack devs just have to do it right, I just figured that the same problem biting the same pack twice in one minor version release cycle indicated possible room for improvement.
I can do the "fix" for the single flower only. Its just that if the flower is in a tag it wont work.