Resourceful Config

Resourceful Config

Mods
32M Downloads

[Bug]: Missing icon error fills the game log

costantino2000 opened this issue ยท 0 comments

commented

Bug Description

The mod is missing an icon, and when using Mod Menu the render thread error in the log is pretty large, making it harder to look for other unrelated problems:

[Render thread/ERROR] (Mod Menu | FabricIconHandler) Invalid mod icon for icon source resourcefulconfig: icon.png
 java.nio.file.NoSuchFileException: /icon.png
	at [email protected]/jdk.nio.zipfs.ZipFileSystem.newInputStream(ZipFileSystem.java:861) ~[jdk.zipfs:?]
	at [email protected]/jdk.nio.zipfs.ZipPath.newInputStream(ZipPath.java:751) ~[jdk.zipfs:?]
	at [email protected]/jdk.nio.zipfs.ZipFileSystemProvider.newInputStream(ZipFileSystemProvider.java:270) ~[jdk.zipfs:?]
	at java.base/java.nio.file.Files.newInputStream(Files.java:159) ~[?:?]
	at com.terraformersmc.modmenu.util.mod.fabric.FabricIconHandler.createIcon(FabricIconHandler.java:34) ~[modmenu-11.0.1.jar:?]
	at com.terraformersmc.modmenu.util.mod.fabric.FabricMod.getIcon(FabricMod.java:169) ~[modmenu-11.0.1.jar:?]
	at com.terraformersmc.modmenu.gui.widget.entries.ModListEntry.getIconTexture(ModListEntry.java:195) ~[modmenu-11.0.1.jar:?]
	at com.terraformersmc.modmenu.gui.widget.entries.ModListEntry.render(ModListEntry.java:72) ~[modmenu-11.0.1.jar:?]
	at com.terraformersmc.modmenu.gui.widget.ModListWidget.renderListItems(ModListWidget.java:265) ~[modmenu-11.0.1.jar:?]
	at net.minecraft.client.gui.components.AbstractSelectionList.renderWidget(AbstractSelectionList.java:188) ~[minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.gui.components.AbstractWidget.render(AbstractWidget.java:66) ~[minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at com.terraformersmc.modmenu.gui.ModsScreen.render(ModsScreen.java:326) ~[modmenu-11.0.1.jar:?]
	at net.minecraft.client.gui.screens.Screen.renderWithTooltip(Screen.java:117) ~[minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.renderer.GameRenderer.mixinextras$bridge$renderWithTooltip$177(GameRenderer.java) ~[minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.renderer.GameRenderer.wrapOperation$zdf000$fabric-screen-api-v1$onRenderScreen(GameRenderer.java:1586) [minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.renderer.GameRenderer.render(GameRenderer.java:913) [minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1285) [minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:882) [minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:256) [minecraft-clientOnly-d2355a93f2-1.21-loom.mappings.1_21.layered+hash.1837964949-v2.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.15.11.jar:?]
	at net.fabricmc.devlaunchinjector.Main.main(Main.java:86) [dev-launch-injector-0.2.1+build.8.jar:?]
[Render thread/WARN] (Mod Menu | FabricMod) Warning! Mod resourcefulconfig has a broken icon, loading default icon

How to Reproduce?

  • Install Resourceful Config and Mod Menu
  • Open Mod Menu
  • The error appears in the log

Expected Behavior

I believe the mod would benefit from the inclusion of an icon, even a dummy one, to make this error disappear.
Alternatively, Mod menu allows specifying custom metadata in the fabric.mod.json file to mark the mod as a library, hiding it from the list and making the error disappear.

Version

3.0.3 and previous

Mod Loader Version

1.21 - 0.15.11

Mod Loader

Fabric

Logs or additional context

No response