Resourcify

Resourcify

840k Downloads

Resource Pack Update Detection Issue

Decryptu opened this issue ยท 3 comments

commented

Environment

  • Minecraft Version: 1.21.1
  • NeoForge Version: 21.1.93
  • Resourcify Mod Version: 1.6.0

Resource Pack Information

Issues Observed

  1. Inconsistent Update Detection:

    • Modrinth source correctly shows "Up to date"
    • CurseForge source incorrectly shows update button for version beta 1.3.0 (which is lower than the installed version of 1.3.1)
  2. "Update All" Button Behavior:

    • Button remains visible regardless of selected source
    • Can click "Update All" even when Modrinth is selected and shows "Up to date"
    • This seems inconsistent with the expected behavior
  3. Update Button Functionality:

    • Clicking the update button results in infinite loading
    • No actual update occurs

Additional Notes

  • The resource pack version (1.3.1) is currently the latest on both platforms
  • The update detection system seems to be showing false positives for updates maybe because of the beta/release channel difference. (Beta = 1.3.0 / Release = 1.3.1)

Screenshots

ig curse
ig modrinth

Steps to Reproduce

  1. Install Resourcify mod with NeoForge 21.1.93
  2. Install E19 - Cobblemon Minimap Icons v1.3.1
  3. Open in-game UI
  4. Observe update detection behavior for both Modrinth and CurseForge sources
  5. Attempt to use update button

Expected Behavior

  • Both sources should correctly identify that v1.3.1 is the current and latest version
  • "Update All" button should only be visible when updates are actually available
  • Update button should not appear for already installed versions
commented
  1. This is probably a sorting issue somewhere, I'll look into it.
  2. Yeah oops this is a small oversight, I'll see if I can leave the button out if none of the sources selected have an update available.
  3. Do you mean that if you select the curseforge source and click update nothing happens? I'll look into it.

Thank you for your very detailed report!

commented

Sorry I forgot to mention, the infinite loading was when clicking on "update all", not the single "update" button next to curseforge, the curseforge one is working

commented

The problem for the first issue seems to be that Resourcify expects CurseForge to give back the list of versions sorted by upload date, curseforge being curseforge, it does this most of the time but not all of the time, why? I have no clue.