RFTools

RFTools

74M Downloads

Advance Powercell Capacity Overflow

glitchyg opened this issue · 15 comments

commented

If a powercell network has over 2,147,483,647 (Rough guess) energy the network goes into the negative and can not be easily fixed.

commented

Using RFTools 1.12-7.29 and RFToolsdim 1.12-5.52

Breaking an advanced powercell caused all the powercells in the same network to become -90M each.

commented

This should in theory not happen anymore in RFTools 7.30 and McJtyLib 2.6.5. Can you confirm this?

commented

It doesn't happen all the time, it was just the once, but it does average out the negative RF to any other power cells added to the network (which is working as intended)

Will continue to test in the mod pack it happened in once RFTools is updated in it on the server. It's not a repeatable bug so difficult to test.

commented

same thing happening to me, RFtools 1.12-7.3.2 - modpack FTB Revelation.

commented

Do you know of a set of steps to reproduce this? Currently, I can't reproduce it myself, so there's basically nothing I can do.

commented

Draconic Evolution implemented an extension of the RF API to use long for capacity. Is there any reason you couldn’t use that? Better yet, is there any reason you couldn’t use BigInteger for capacity?

commented

I previously asked that myself. @McJty said he doesn't want powercell networks to hold more energy than can fit in an int.

commented

I'll add protection that it cannot go beyond that

commented

Would you have any advice on how a server admin could correct this issue if they already have it? We tried breaking a few but it stayed negative.

commented

Hmm. Might be hard to fix I'm afraid

commented

Fixed next release. If the value is negative rftools will also auto correct it to maximum contents of the cell network

commented

Weird...

commented

Pack: All the mods 3 version 3.2b. Forge: 2478. RFTools version: 1.12-6.13. We are having this issue on a server.
https://imgur.com/a/GLfwV This is of course right before it reverts to negatives.

commented

Just a quick note on this issue. Might be the case that it should be a separate issue instead. The cell channel seems to cap at MAX_INT capacity internally, but the GUI still wraps to negative.

See attached screenshots of WAILA's info vs Cell's GUI.
gui
waila

commented

The issue can still occur in rftools-1.12-7.61.
I changed the advancedFactor config from 4 to 40, and quite a few of my players reported that their Powercell Networks had overflowed into negative numbers.