RFTools

RFTools

74M Downloads

The Storage Scanner counts the contents of double chests twice

undeadbanana opened this issue ยท 18 comments

commented

Unsure why this is happening but the quantity of items in the scanner is displaying twice as high as it should be. e.g; Shows 4 ender pearls when there's actually only 2. Using newest versions of your mods as of January 25th

commented

Screenshot of the inventory in question in the world, and one of the scanner GUI?

commented

Actually, just figured it out. It's scanning some double chests twice. Scans them as single inventories.

(images in next comment)

I just did a scan because I thought maybe upgrading some Iron Chests messed with something. The scan did get rid of some extra chests, started with 16 in Scanner GUI and new scan only showed 14. Gonna rescan again.

commented

2018-01-25_17 09 52
2018-01-25_17 09 59

I'll put the images here so you don't have to go to an external site

commented

It's only doing this double-chest-as-single-chest scan to two of my chests.

commented

Can you find any kind of pattern in which double chests it happens with and which ones it doesn't?

commented

Actually, I can. Just noticed it's happening to a third chest; All 3 chests despite being Spruce/Oak say they're from the mod Quark. The only Spruce chests that it's not happening to are Minecraft vanilla chests.

commented

I wouldn't say it applies to all modded chests, I'm using some chests from Iron Chests and those are free of this bug. As of right now, it's only affecting the Quark chests. Scanning double chests as single chests but reading the entirety of the double chests contents for each scan.

edit: Also have an Immersive Engineering crate that isn't affected.

commented

Not sure if this is needed but I'm using Quark-r1.4-122.jar, updated yesterday January 24th.

commented

Is it accurate that it applies to all modded chests that occupy multiple blocks?

commented

Yes, that's accurate; I can't find any other double chests at the moment.

commented

Hmm, in my testing, this happens to vanilla double chests too. Can you confirm whether this is the case on your end? (Did you possibly set only one piece of the double chest as routable?)

commented

You're right, it's all double chests

commented

(forgot to remove the extra screenshot)

2018-01-26_17 12 43
2018-01-26_17 12 50
2018-01-26_17 12 54

commented

This might also be the same problem; I've got two powercells linked, when one is placed I have about 150k RF, when I place the other in the world it says I now have 310k RF in the linked powercells.

Ignore first screenshot

edit: forgot I could just upload here.

commented

That looks unrelated; can you open a new issue for it?

commented

I have verified that this is affecting minecolonies racks as well, when reading contents from the warehouse, everything is doubled. This is because the racks as sets as pairs in the warehouse, anyway to remove that behaviour?

commented

Will be fixed in the next release. I confirmed that this fixes vanilla double chests, Quark double chests, and MineColonies racks. It's possible that other mods' blocks may still have this problem. If so, there's nothing more we can do about it on our end. They'll need to do two things on their end: use IItemHandler instead of IInventory, and make sure that their IItemHandlers returned by different blocks of the same inventory are equal according to the equals and hashCode methods.

commented

This seems to affect the "Racks" in MineColonies too. It counts each block a rack occupies as a separate inventory, thus duplicating everything inside in 2-block wide racks (racks can be 1 or 2 wide, like a normal chest).