RFTools

RFTools

Mods
74M Downloads

[1.12.2] Elevator block crash-to-desktop caused by P2P redstone update on AE2 network change

ArcanoxDragon opened this issue ยท 1 comments

commented

Well this is a doozy. I've had two crash-to-desktops tonight with the stack trace pointing back to the RFTools elevator block, in particular a method on TileEntityBuilder that the elevator calls on a redstone update. Here's the stack trace:

java.lang.NullPointerException: Unexpected error
	at net.minecraft.entity.player.EntityPlayer.<init>(EntityPlayer.java:160)
	at net.minecraft.entity.player.EntityPlayerMP.<init>(EntityPlayerMP.java:158)
	at net.minecraftforge.common.util.FakePlayer.<init>(FakePlayer.java:42)
	at net.minecraftforge.common.util.FakePlayerFactory.get(FakePlayerFactory.java:61)
	at mcjty.rftools.blocks.builder.BuilderTileEntity.getHarvester(BuilderTileEntity.java:179)
	at mcjty.rftools.blocks.elevator.ElevatorTileEntity.isValidPlatformBlock(ElevatorTileEntity.java:362)
	at mcjty.rftools.blocks.elevator.ElevatorTileEntity.isPlatformHere(ElevatorTileEntity.java:601)
	at mcjty.rftools.blocks.elevator.ElevatorBlock.getRedstoneOutput(ElevatorBlock.java:61)
	at mcjty.lib.container.GenericBlock.func_180656_a(GenericBlock.java:102)
	at appeng.parts.p2p.PartP2PRedstone.onNeighborChanged(PartP2PRedstone.java:168)
	at appeng.parts.CableBusContainer.onNeighborChanged(CableBusContainer.java:836)
	at appeng.block.networking.BlockCableBus.onNeighborChange(BlockCableBus.java:134)
	at net.minecraft.world.World.func_175666_e(World.java:3795)
	at net.minecraft.world.World.func_175713_t(World.java:2470)
	at net.minecraft.world.chunk.Chunk.func_177436_a(Chunk.java:575)
	at net.minecraft.world.World.func_180501_a(World.java:342)
	at net.minecraft.block.Block.removedByPlayer(Block.java:1179)
	at de.ellpeck.actuallyadditions.mod.util.WorldUtil.playerHarvestBlock(WorldUtil.java:424)
	at de.ellpeck.actuallyadditions.mod.items.ItemDrill.tryHarvestBlock(ItemDrill.java:464)
	at de.ellpeck.actuallyadditions.mod.items.ItemDrill.breakBlocks(ItemDrill.java:410)
	at de.ellpeck.actuallyadditions.mod.items.ItemDrill.onBlockStartBreak(ItemDrill.java:236)
	at net.minecraft.client.multiplayer.PlayerControllerMP.func_187103_a(PlayerControllerMP.java:130)
	at net.minecraft.client.multiplayer.PlayerControllerMP.func_180512_c(PlayerControllerMP.java:322)
	at net.minecraft.client.Minecraft.func_147115_a(Minecraft.java:1478)
	at net.minecraft.client.Minecraft.func_184117_aA(Minecraft.java:2266)
	at net.minecraft.client.Minecraft.func_184118_az(Minecraft.java:2018)
	at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1806)
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1096)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397)
	at net.minecraft.client.main.Main.main(SourceFile:123)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
	at org.multimc.EntryPoint.listen(EntryPoint.java:143)
	at org.multimc.EntryPoint.main(EntryPoint.java:34)

This happened when I broke an AE2 Energy Acceptor one block away diagonally from an Elevator block. The Acceptor was on a simple network with itself and two Redstone P2P nodes. One of the nodes was attached to the Elevator block to send it a call signal. It seems breaking the Acceptor triggered a Redstone update on the Elevator block (P2P node went offline), and for some reason, it encountered a Null exception when checking for the presence of the elevator platform.

This is on:

  • Minecraft 1.12.2
  • Forge 2601
  • RFTools 7.24
  • RFTools Control 1.8.0
  • RFTools Dimensions 5.51

Mod pack is Direwolf20 1.8.0 for 1.12.2.

commented

Fixed in 7.27