RFTools

RFTools

74M Downloads

Builder should handle an exceeded maximum dimension or offset better

xenexelen opened this issue ยท 16 comments

commented

I use two Querrys, one clearing quarry upward sealevel, one normal quarry downways.

I set set the first and the last point at the chunkborders. The first hase an offset by 2 fields, the second works correct (i have been able to reproduce it 3 times until now).

MC 1.12.2
RFTools 1.12-7.27

commented

2 field offset is a good case... i have also had cases where the offset was much higher (usually 0 or 2 to the east, but also several chunks in one direction [if i choose a great area with 100-1000 chunks], offset up...)

commented

Screenshot of the shape card's interface, and the builder with preview/support mode activated? Also, how are you setting up the shape card?

commented

Sorry, i haven't time until now. I test it again, but short: I haven't change anything in the shape card or builder-interface. Before your answer i haven't know the shape cards interface... (I use RFTools only since a short time).

commented

Right-click the air while holding the shape card.

commented

With the actual version i haven't reproduce the effect until now. I observe this a while (but i haven't not much time).

commented

I have not been able to reproduce it yet, but I have not been able to invest the time I had in the initial testing. It may be that this issue is resolved in the current release, but there is no guarantee for it. I keep watching the problem (but almost only on weekends to test).

commented

I don't understand. Are you saying that the problem is gone in the latest version?

commented

Okay, I'm going to close this for now then. If you do manage to reproduce it in the future, just post your findings here and I'll reopen it.

commented

I try it (i haven't made videos until now), but first i create a new MC-Path test with only RFTools/mcjtylib and a new Forge-Version... I would like to rule out that it is not due to other mods.

commented

https://youtu.be/8BmqG6Gpqxg

Mods:
mcjtylib-1.12-2.6.4
rftools-1.12-7.29

Forge: 1.12.2-14.23.2.2611
No changes on default mod-configuration

Savegame: https://simerion.de/uploads/RFToolsBugReport.zip (user for access: guest / uploadsforguest)

Coordinates (for teleport-command):
House with Builder in it -284 63 -157
Start -284 64 -141
End 417 128 137

commented

Today, it occurred again. 2 Field offset (now to south). The preview shows the wrong area "correct". An area offset by 2 fields to the south, opposite to the 2 selected corners. It was a great area (832 chunks), the first corner one blocks above oceanlevel, the second 63 blocks above oceanlevel.

commented

Next try: place the start block (first corner) 3 blocks north from the old one, use the same end-block. Now the offset are 4 to south (i expected 0 or 2).

commented

Can you upload a video showing this problem?

commented

https://github.com/McJty/RFTools/blob/a315cd0c26d8a9f2b0b1dd3a69e24e8bbae0559e/src/main/java/mcjty/rftools/blocks/builder/BuilderConfiguration.java#L49-L50

The dimensions and offset of the shape card that you configured are greater than the builder's maximum by default (you have an offset of 348 and a width of 702). Either select a smaller (and closer) region or turn these up.

commented

Okay... but then, a error-handling would be nice (The builder should show: "to large area"? and not start the work). The problem is: the area are moved (the offset can be outside of the orignal area!).

commented

Good points. 2 things to fix:

  1. I'll add a warning to the builder when you exceed one of its maxima
  2. I'll make sure that the space it operates on is always a subset of the requested space