Dimensional Shard Ore not registered in OreDictionary
Saklad5 opened this issue · 3 comments
Issue description:
Dimensional Shard Ore does not have an OreDictionary entry. This is particularly annoying with mods that filter for ores, such as Industrial Foregoing and its Ore Processor.
Steps to reproduce:
N/A
Versions:
- Minecraft: 1.12.2 (1.12.2)
- Forge: 14.23.1.2587 (14.23.1.2587)
- McJtyLib: 1.12-2.6.2 (2.6.2)
- RFTools: 1.12-7.23 (7.23)
Possibly incompatible mods:
FoamFix
Relevant logs, if any:
N/A
For reference, the code in question: https://github.com/Buuz135/Industrial-Foregoing/blob/ac9a853cd4cfb5e24db1880306dc641ecdf12ccb/src/main/java/com/buuz135/industrial/utils/ItemStackUtils.java#L159-L164
We need to give it an oredict name that starts with ore
.
oreDimensionalShard
would be fine.
This is also important because damage values on blocks are deprecated in version 1.13 of Minecraft. Dimensional Shard Ore variants won’t share an ID anymore, unless you do something with NBT.