RFTools

RFTools

74M Downloads

Crafters don't reactivate when shift-clicking items into an existing stack

xxMattewxx opened this issue ยท 10 comments

commented

Issue description: Sometimes, the Crafter (tested tier 1, tier 2 and tier 3) will stop working until I manually remove an item from its inventory (even if the Crafter slots are not full)

Steps to reproduce: Add a recipe to the Crafter, add resources for the crafting of the item(s) and wait till it crafts all of the items. Then, add more of the same resources and instead of the machine crafting it will simply stop working (until I remove items from the output which makes the crafting process start once again.)

Versions:

  • Minecraft: 1.12.2 *Had it working fine when I was playing at 1.10.2
  • Forge: 14.23.3.2676
  • McJtyLib: 2.6.7
  • RFTools: 7.33

Possibly incompatible mods and versions: OptiFine (HD_U_D2)

http://prntscr.com/jdxamk

commented

Clicking any of the buttons from the GUI also seems to make the Crafter work once again. After it stops the crafting process tho, it will stop working :V
Sometimes it will even stop working completely (after I remove the output items): http://prntscr.com/jdxcca

commented

When you say "add more of the same resources", how exactly are you adding them? Manually via the GUI or with automation? If manually via the GUI, can you upload a video of you adding them? If via automation, can you show your automation setup?

(Note to self: probably caused by 73f6bb5 and probably will be fixed by adding another noRecipesWork = false; somewhere)

commented

Thanks for the quick reply. I'm basically shift-clicking the items from my inventory to the machine so yeah, through the GUI. Will try automating it in a second and post the result here.

commented

Okay, I'll see if I can reproduce it. As a workaround, try moving the items without using shift+click.

commented

Works fine using automation w/ EnderIO. As soon as 3 glasses and 1 iron are in the machine, it crafts the recipe and so on.

commented

I can't seem to reproduce this. Can you do these two things?

  1. See if this happens with a recipe from vanilla or from RFTools, so I can test this without any other mods
  2. Upload the video of exactly what you're doing to add the items
commented

Sure! I've got the video, it is uploading right now but may take a while as my internet provider is kinda crappy. Anyway:

  1. I've tried this with a redstone repeater (as I can't reproduce the bug with recipes that only need one resource, like furnaces or chests.) Pick up 1 stack of redstone, 1 stack of stone and 1 stack of redstone torch. Then, add the stacks of redstone and stone to the machine (through shift-clicking) and the redstone torchs you're gonna take 3 of that stack - so you now will have two slots in your inventory (one with 61 redstone torchs and another with 3 redstone torchs). Shift-click the 3 redstone torchs (the machine will craft 1 repeater by then) and after the crafting of that repeater stops, shift-click the rest of the redstone torchs. In my computer I've got a 100% reproduction rate, the machine won't craft anymore until I take one of the stacks in its slots and put them back (this time either shift-clicking or simply dragging items with the mouse)

  2. Video is uploading, the estimated time for upload is 30 min atm.

commented

Okay, I managed to reproduce it with those instructions, so you don't have to finish uploading the video if you don't want to.

commented

Thanks very much then. Glad to see I've helped in something! Love the mod.

commented

Will be fixed in the next release.