Issue description:

Unable to remove items contained in a Modular Storage Unit with a Storage Scanner. This is brand new behaviour introduced by the latest update. These two units are connected via the XNet RFTools Storage network type.

Steps to reproduce:

Attach XNet connector to a Modular Storage unit and a Storage Scanne and attempt to withdraw items stored in the Storage Unit. In my case I had about 1084 dimensional shards I was trying to withdraw. I got two stacks out and then could not remove anymore. If I reinsert the shards I can take the same ones back out.

Moving the shards to another storage system like Storage Drawers allows all of them to be withdrawn.

TBF it could also be an XNet issue since it's the connecting mod. But I've verified all the connection settings are proper and they are are same settings on the drawer controller and the MSU.

Versions:

Minecraft: 1.12.2
Forge: 2705
McJtyLib: 3.0.1
XNet: 1.7.1
RFTools Control: 1.9.0
RFTools: 7.53

Possibly incompatible mods and versions:

SpongeForge: 3169
FoamFix: 0.9.9.1-Anarchy
BetterFPS: 1.4.8

Relevant logs, if any:

Nothing I've noted in the logs yet.

Addendum:

I ruled out the XNet Connection but disabling the channel and adding the inventories back to the scanner by range scanning. Issue remains the same.

However it's not just the storage unit. Items cannot be extracted from certain drawers/units. The Items from a specific MSU or drawer are all not extractable if it happens. I can have found that out of my 4 MSU's I can extract from 2 of them. And all my drawers are connected to the scanner via my drawer controller but only certain drawers exhibit issues.. the rest work.

I cannot find anything specific about the ones that fail. It seems to be random at the moment. Only thing I can say is the ones that don't work are consistent. I will try to gleam more out of this as I can. Nothing shows in the logs one client or server though.

Can you show a screenshot of the storage scanner gui?

Sure Thing:

I would avoid using a drawer controller like that. The drawer controller and the rftools storage combination has been known to cause troubles in the past due to the way the the controller works. It is normally better to link the storage scanners to the individual drawers and not include the controller

Ok, that's unfortunate but I can work around it. Doesn't explain not being able to pull from the storage units however?

Also not if you don't use XNet? Because I see you're still using XNet as range

I set it back to that last night after testing without XNet. I disabled the RFTools channel and scanned and added the MSUs back manually.

I should mention, this setup worked flawlessly until we updated mods. Not sure what triggered this scenario. I'm going to remove the drawer controller and try without XNet again.

Here we go, XNet is disabled and I've highlight the MSU that I cannot pull from. Even with the direct connection nothing will extract from the second and third MSUs, the fist and fourth are fine.

With 'nothing will extract' you mean that you can't pull items out with the gui. right?

Correct. Inserting works fine. And everything works as expected if I go directly to the unit itself.

Very strange... I will try to reproduce this later

I am beginning to suspect bugged blocks somehow but not sure. I went back to XNet and connected one of the drawers can cannot be withdrawn from via the scanner directly and it still won't let me pull items. Going to try replacing the MSU that's bugged with a new one and see if things change. Also beginning to wonder what would happen if I replaced the Scanner itself

Such a weird issue to troubleshoot. I managed to fix the two completely non-functional MSU's by emptying them, breaking them, changing the storage module, and replacing them. I put the stuff from them in one of the units that worked and now that one seems to be partially acting up. Now it's only specific items from that storage unit that are acting up. I can extract black concrete, but I cannot extract black concrete powder. :/

Oh that's strange. Would be great if you can find a pattern. Also there is no item filter in the modular storage block?

No filters of any kind.

Still trying to find a pattern here. I rolled back the recent update we did for your mods and found the issue was unchanged, then updated to the releases from 3 days ago and found it unchanged.

So far I've found that the following items seem to be consistent in not being able to be pulled from the storage scanner:

• Black Concrete Powder
• Carrots
• Dimensional Shards

Took this to a local game and boiled the issue down some more. Local game takes out SpongeForge and Permissions plugins from the picture.

Reproduced it easily with 1 Scanner, 3 MSUs with Tier 3 disks and Storage Drawers, with Black Concrete and Black Concrete Powder and Carrots. Was able to put things in through the scanner, but could not take them back out.

This problem is somehow caused by Astral Sorcery 1.9.1 on 1.12.2, rolling Astral Sorcery back to 1.8.10 resolves the issue.

These two mods operate in two seemingly very seperate spaces so I'm not sure how this conflict is occurring, but I'm guessing Astral Sorcery is doing something funky.

Astral Sorcery seems to use some sort of ephemeral network similar to the RFTools scanner.. I wonder if the two are bumping into each other somehow.

Starlight network has nothing to do with anything except active starlight connections, so no, that is not part of it.

Moving beyond 1.8.10 AS does invoke a new system (amulet) iterating items to get stack sizes during pack load, but I believe that was the only thing changed relating to items outside AS.

Finally narrowed this down to 6 mod candidates, working through it and should have an update with the culprit soon.

So, some other things learned: vanilla double chest with a single stack of carrots within scanner range causes the same issue, as it reports as 128 carrots vs the 64 it actually is. It's crossing the 127 item threshold. Vanilla cobble stairs, same deal.

Edit for clarification: Starring both "halves" of a double chest causes this. Unstarring one and using the all routable, or just using only the single chest selection causes it to properly withdraw again since it displays a stack size of 64 again.

I got the same problem with a storage scanner and a colossal chest. Netherrack, quartz, black quartz are a few of the items I can't pull in the scanners GUI

Thanks for all the feedback. I'm not ignoring this. Just collecting information on how to fix this (if it is my side)

Glad others have experienced this same problem.

I use a room full of modular storage blocks with a scanner in the center detecting them all. I'm not using xnet, everything is at a range of 7 blocks from the scanner.

I can insert and withdraw items through the scanner, terminal, or tablet but some items stop being removable. This has just started happening since the latest update as far as I can tell.

The items that stop being removable through the scanner have all been stackable items such as dirt, ingots, logs, redstone (blocks and dust), clay, etc. They are still available to the built-in crafting table but I can't retrieve them into my inventory. If I want to access the items once this happens I have to manually take them from the inventory they're stored in.

I've found that sometimes pulling some out manually and then putting them back in allows the recently replaced ones to be retrieved through the scanner but this is temporary. I'll try to remove the same things later and the same issue will occur.

This has me totally baffled... I cannot reproduce this no matter what I do. Is this single player or server btw? Also from what version on did this start fo fail?

So...using Astral Sorcery 1.9.2 and your debug version of the 7.54 jar, I cannot get it to reproduce anymore in single player.

Reverting back to AS 1.9.1 returns the issue in the exact same world.

I expect it was a problem relating to the Amulet-Capability being attached to "empty" itemstacks due to a code error that was fixed in AS 1.9.2.

Logs:
(Working Correctly)
https://gist.github.com/Doomgull/837ff961fad6346239913c5109a387b0
and
(Not Working)
https://gist.github.com/Doomgull/973f5037f9acba42cc2c27d8d0e2bfcc

Ok, but others had the problem using only rftools I thought. So if they can still reproduce it then I'm still interested in those results

I believe all the other entries in this thread so far also had astral sorcery involved, because of the pack they were using. I may be mistaken, though.

Ok. a few questions and an experiment.

a) does it fail from the storage tablet and from the scanner directly or only from the tablet?
b) does requesting a single item work in all cases (i.e. shift click)

Also I made a debug version to help diagnose this problem which is available here:

http://jenkins.k-4u.nl/job/RFTools%201.12/lastSuccessfulBuild/artifact/build/libs/rftools-1.12-7.54.jar

It would help a lot if you could try to reproduce this issue with this version. In the log it should show 'REQUEST ATTEMPT' blocks. I'm interested in those. Thanks!

a) I've only used the storage scanner with a colossal chest.
b) No requesting single item fails too. I tried it with over 200 clay in the colossal chest. Single player world. Both stack and single item failed. A lot of other item worked though.

I've tried this in both single player (Mech and Magic) and on the Mech and Magic official server.

Version used is 7.54

a) I mean do you use the storage scanner directly or through the tablet?

The version I linked is a special debug version. If you can I'm very interested if you can reproduce it with that version and with the debug output

I'll first say that the problem occurs using the tablet OR the scanner. Doesn't matter which.

When I first encountered this problem it was on a multiplayer server running the latest version of the DW20 pack. I just tested it in a brand new DW20 single player world by cheating in 3 modular storage units with tier 3 modules, a storage scanner, a tablet, and a bunch of dirt.

I tested at both the tablet and the scanner and the results were the same so I'm just going to say scanner from here out.

I dropped all the starter books and random seeds that popped into my inventory into the scanner. Those were easily removed through the scanner.

I dropped 1 stack of dirt into the scanner and it was easily removed. I added small amounts of dirt in increments and kept testing whether it could be removed. The conclusion is definitely that the problem occurs as soon as the stack reaches 128. At 127 I can remove all the dirt. At 128 and above, I cannot remove any dirt through the scanner.

I also tried splitting the stacks among inventories, thinking that maybe it's just if the dirt in a single inventory >= 128 but, no. Having 64 in one modular storage unit and 64 in another, no dirt is removable through the scanner. Having 64 in one and 63 in another, all dirt can be removed through the scanner normally.

I haven't had an opportunity to test with your debug version yet but as soon as I get enough pc time, I will.

Astral Sorcery is in Mech and Magic so I use that. Version 1.9.1
Will update to 1.9.2 solve this issue?

It did in my tests, but that was only rftools/as, not the mech and magic pack. Would be good to confirm there wasn't another possible interaction at fault, I would imagine.

@Woodstove can you test with msnually updating AS to 1.9.2?

Sorry @McJty I will be testing this tommorow. I have been very busy.

So any news? Is this bug still there? Anyone has been able to test this with my debug version?

For me the bug is fixed with updating AS to 1.9.2. I can now completely use this wonderful mod again. And I learned there was an tablet.

My apologies as well @McJty , I have been traveling for work and unable to get on Minecraft. Probably going to be another week or two before I can.

@McJty @Doomgull Confirmed fixed with 1.9.3