RFTools

RFTools

Mods
74M Downloads

Builder crash when attempting to place fluid with non-existing block

tomdodd4598 opened this issue ยท 1 comments

commented

Issue description: NullPointer crash on builder trying to place non-existing fluid block.

Steps to reproduce: Give the builder a fluid which does not have a corresponding block and try to place it. These lines assume that the block exists, and so the game crashes.

Versions:

  • Minecraft: 1.12.2
  • Forge: 14.23.5.2838
  • McJtyLib: 3.5.4
  • RFTools: 7.72

Relevant logs, if any: Crash report

commented

Offending line:
https://github.com/McJtyMods/RFTools/blob/1.12/src/main/java/mcjty/rftools/blocks/builder/BuilderTileEntity.java#L1248

As stated above it is inferred the block exists but is not checked. Requires a null check on the block before trying to set the state in-world.