Prevent unnecessary testRecipe when draw GUI
robinxb opened this issue · 0 comments
Issue description:
FPS significantlly drops when open storage module.
My test results:
SP: 130->60 fps
MP: 80 -> 15 fps
click me to view analysis
Steps to reproduce:
Press F3 to show FPS.
And just open a storage module.
You can find the FPS is much lower than before.
Versions:
- Minecraft: 1.12.2
- Forge: 14.23.5.2847
- CompatLayer (only if on Minecraft 1.10 or 1.11): Nope
- McJtyLib:mcjtylib-1.12-3.5.4
- RFTools: rftools-1.12-7.73
Suggestion Maybe?
Cache this slots infomations, when next draw, check if it's the same.
If they are, then skip the rest.
I don't know if it's fine, or this could simply be solved by add a extra time check, but I don't think it's the best solution.
Why don't modify and submit a PR
I've tried, since the maven of waila is down, and the forge 14.23.5.2846 always throw error at patching, I've spend so many hours and finally the client crash when load the mod I built.
So I ended up with giving up. Maybe when I am brave enough again. 😭
Also there's a related issue I think it might be the same problem. Modular Storage - FPS Loss + Search Field laggy #868