RFTools

RFTools

74M Downloads

Offset of Dimensions

a-rat-girl opened this issue ยท 19 comments

commented

In order to improve MystCraft compatibility, would it be possible to add a config option to offset the Dimension IDs? Possibly have them start at Dimension -100, and move back? DIM-100, DIM-101, DIM-102? It would help stop certain crashes we've been having with MystCraft.

commented

Or just have configurable dimension ids

commented

In my custom modpack I'm running Mystcraft together with RFTools with no issues at all. What kind of crashes are you getting? The problem is that I have no influence over the id's that I get. I simply request the next available id from Minecraft itself.

commented

Can you describe exactly how this happens? This shouldn't be possible at all.

commented

Also is this a server log? When exactly does this occur?

commented

This happens in singleplayer when attempting to create/join a world

commented

I haven't experienced this myself, but it happens to certain people in combination with MystCraft

commented

From my investigations into these logs last night it looked like a dimension was created with an already existing dim id.

commented

I think the presence of mystcraft is a coincidence. I think the problem is with RFTools itself. I have a theory but I would need to have more information about this. My theory is there was an earlier crash while trying to generate this dimension and RFTools now has wrong information about what dimensions it manages and what not.

commented

This is about all we have. It happens when creating a new world, and then past that, it just keeps crashing that world.

commented

I think this is probably going to be another issue that has nothing to do with the range of the dimension ID. But I'm need more information.

commented

Can someone describe me the exact steps used to reproduce this problem? i.e. from starting new world, to creating first dimension and so on.

commented

No, when you create a new world. Not a new dimension, but a new singleplayer game. You clikc the new world button, put in the settings, and crash. All we have to do is open up minecraft, singleplayer/new world/create new world, and then a crash. I never got the crash from joining the world, only from creating the world.

commented

McJty are you on IRC or something? I can get you a build of this instance with RFTools

commented

I'm on irc right now (in #rftools).

Does this happen all the time or only in certain situations? Many people are using RFTools (also in combination with Mystcraft) so I'm very curious about this.

commented

Thanks to the help of tfox83 I found the issue. I will work on a bug fix and test it further. I could reproduce it by first connecting to a server which had RFTools dimensions and then disconnecting. Then without leaving MC create a new SSP world -> crash. Seems that the dimensions are not properly cleaned up when logging out from a server.

commented

I will have a fix out by tomorrow

commented

\o/

commented

Should be fixed now. Reopen if it isn't