New Environmental Controller particle effect
wlhlm opened this issue · 2 comments
One thing in this otherwise excellent mod always struck me as odd, and that is the Environmental Controller active particle effect. I think it could be improved using vanilla particles, specifically mobSpell
. The Controller even has them printed on the front — what is the reasoning behind the current "floating spheres" effect? Maybe Performance?
Here's a quick hack of what I'm imagining it could look like:
left: old - right: new
What do you think?
In case someone is interested, here's what I did to change the particles:
https://gist.github.com/wlhlm/cacb2f8210775076cab3
I borrowed the particle spawning from MaterialAbsorberTileEntity.java
and modified it slightly. I don't know anything about Forge modding and my Java knowledge is also very limited, so this could totally be the wrong way to approach it (for example I've seen other mods use randomDisplayTick()
for particle spawning), but maybe it helps as a starting point.