RightClickHarvest

RightClickHarvest

3M Downloads

Thank you for the mod!

AlexKVal opened this issue ยท 2 comments

commented

Hi @Jamalam360 ๐Ÿ‘‹

Thank you for this nice handy mod ๐Ÿ™
I've been using it to learn the MC-modding (for both (Neo)Forge and Fabric) and Java language.

Here are the results of my learning. Feel free to use them if you like the result in any way :)

AlexKVal#1 some code refactoring to better understand the structure of the mod. The 'static-only methods' way is preserved. The tests are green. Everything works as before, including the different configuration settings combinations.

AlexKVal#2 the migration to the 'use Classes' way. I like this one, b/c now many methods could be "mixed in" in the MC classes by making the code to (arguably :)) even easier to understand and expand.
As a bonus, one small (insufficient) bug is fixed along the way, and it is easy to expand the radius-harvesting to the Sugar Cane and Cactus as starting blocks. That would be just "one method swap" change (details in the PR comment)

For both branches, I preserved the commits that I was making, so it is easy to see what change and why is done to follow all the path :)

commented

Hi, sorry it's taken me sooooo long to look at this, I'm very busy. The change to use OOP with the BaseHarvester class is definitely interesting, but I don't have time to look through it properly still haha.

One thing I will say, HarvestContext does serve a use - it means that if I want to add another parameter, it's not a breaking change for API users.

Anyway, seems like you're doing well at learning mc modding, good luck!

commented

I understand and totally support you in that it is a lot of changes that would require a lot of time to review,
so that's why I did not raise any PRs.
Though, in theory, it could be split out into smaller reviewable chunks, still even that would be a lot of work on your side.
It cannot be justified in any way b/c this is just a hobby project that "just works" ๐Ÿฆพ
Thank you for your kind words @Jamalam360 ๐Ÿ‘