Server lockup with v1.3.5
Dav92 opened this issue ยท 7 comments
The following happens on SSP and SMP (with both only forge and cauldron) with forge 1231 and roguelike v1.3.5. It doesn't matter wether I have only roguelike or another ~50mods installed.
While generating the map, the server locks up (please look at the screenshot for info on the method).
http://abload.de/image.php?img=profilerr9uh1.png
It happens on a map with the seed -878678536829659803
You can reproduce it by teleporting to the coordinates -923/-6022 (x/z) and then go towards -927/-5492 (http://abload.de/image.php?img=coordslockup99ueo.png). It doesn't happen, if you teleport yourself straight to -927/-5492
This code has been rewritten, going to assume it's fixed for now unless there are new reports on this issue.
Did you fixed this lockup in the newer version (1.3.5+)? We are still playing on that version and got our first lockup this morning and our world is quite large. I see that you did some changes in this file 3 months ago, but did you fix this one? :)
Here's the stack trace of the server thread.
java.lang.Thread.State: RUNNABLE
at greymerk.roguelike.catacomb.CatacombLevel.update(CatacombLevel.java:155)
at greymerk.roguelike.catacomb.Catacomb.generate(Catacomb.java:70)
at greymerk.roguelike.catacomb.Catacomb.generateNear(Catacomb.java:44)
at greymerk.roguelike.catacomb.Catacomb.spawnInChunk(Catacomb.java:133)
at greymerk.roguelike.DungeonGenerator.generate(DungeonGenerator.java:13)
...
I can confirm this problem. I was using WorldBorder with Cauldron, and it kept hanging at the same place. I entered the world and flew along the world border, and eventually the same thing happened. After removing Roguelike, the problem disappeared. Here's a screendump from VisualVM:
I think it's possible that my current method for generating the skeleton of the dungeon can, in extremely rare cases, cause an infinite loop.
This is really old code and my plan is to completely rewrite/replace this part of the codebase for the next release.
Probably won't be much longer until I get to that point.
I can confirm this issue in my modpack. (not trying to advertise, but you need specific settings to make the same world, and this is the easiest way to give them to you... The feed the beast pack code is: Minimatech
the pack has the same name as the code)
Create a Biomes O' Plenty world with the seed 6597839188171159067
and the lockup happens around -2172, 1923
I downloaded the most updated source code and compiled it, did not have the issue with it, and indeed there was a Roguelike dungeon right near there. I don't know if the issue is fixed in the latest code, or if the dungeon is just generating slightly differently, causing the issue to not pop up at that particular dungeon.
Not sure if it's related, but it looks like a tiny desert island managed to spawn a desert temple right near the dungeon (it's funny because the temple is larger than the island, meaning it's just a desert temple in the middle of the ocean) Of course you won't be able to see this unless you also compile the latest code and replace the mod in the pack >.>