Roguelike Dungeons

Roguelike Dungeons

33M Downloads

Getting Double the Amount of Loot Specified

Alan19 opened this issue ยท 23 comments

commented

Sometimes, I would get double the number of loot. For example, if I specify 8 in the quantity property in the loot files, I would get 16 items per chest. I don't know what's causing it but minor changes often causes the loot to go back to normal.
Loot JSON for that Floor: http://pastebin.com/a7jfbEAB
Old Image of Abnormal Loot
2016-12-30_23 52 11

commented

2017-01-22_15 55 31
The json for that chest is in the first post. I fixed the link.

commented

Your file looks okay to me. Can't spot any issues. Are you inheriting in another file? could be somehow the rule is being added twice. Just a guess.

commented

Here's all the configs I'm using. I'll double check if any of the files are inheiting twice.
https://github.com/belathus/Wanderlust-Renewed/tree/master/config/roguelike_dungeons/settings
Edit:Each dungeon only inherits each loot file once, the loot files aren't inheriting anything and the loot is being overridden in each dungeon.

commented

Do other dungeons inheriting the same loot files cause problems?

commented

How to fix it: Learn java and download eclipse so you can code a fix or even hardcode your loot, it may take months.
Easy fix: Divide itemcount by 2 XD

commented

Oooh.... You know what it probably is. You are using biome as your criteria for the dungeon and in some cases perhaps both dungeons are eligible to spawn in the same place (eg: SPOOKY FOREST). So maybe it's actually combining the loot rules from both biome dungeons by adding them twice.

Will have to try that out and see if that's a thing that happens.

commented

But won't that mess up the levels? Nothing else is wrong except for the loot.

commented

After spawning a dungeon in a biome that doesn't overlap with any other files, I'm still getting double loot. Maybe it has something to do with the secret room that I added to abyssalcraft.json

commented
commented

Thanks. I removed it and also tried removing the other loot files. I'm still getting double loot.
2017-01-22_22 42 10

commented

I'm going to try removing each file until I find which file is causing it.

commented

What mod/minecraft version is this for anyway?

commented

1.10.2

commented

Can you provide a screenshot of the loot with the corresponding config file that causes it?
Thanks!

commented

I managed to reproduce this bug in 1.10.2 and 1.11.2

will take a look at it in the debugger, hopefully give me a better idea as to what's going on.

commented
commented

Never mind.. New bug caused by the fix. working it out now.

commented

This one fixes the bug.. which was that multiple inheritances in a file would conflict and override eachother
https://github.com/Greymerk/minecraft-roguelike/releases/tag/v1.5.5.2

commented

Trying it now

commented

I think I managed to fix it. Will need to do more testing, then I'll put up a build and you can try it out.

commented

It's working :)
Before: 2017-01-22_15 55 31
After:
2017-01-23_22 57 22
Should I close the issue?

commented

Great. Looks good.

commented

I'm getting double loot again. The latest configs are still on the GitHub page.