What happened?

I wanna disable this.

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

• Visual
• Recipe Lookup
• Cheat Mode
• Plugin Integration / JEI Plugin Compatibility
• Others

Relevant log output

There was no help format so I'm using the bug format, but nothing here

Anything else?

No response

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

• Yes, and I did not use any paste services other than GitHub Gists.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

• Yes

Still having this issue in 1.21.4, bumping this so the fix above can be officially added.

ok thank you for your reply. By the way, I’ve been using the version you made for 1.21.4 all along, and it’s been working perfectly without any issues.

I'm very pleased that my version works well. Today, I tried to tinker with version 1.21.8 a little, but that proved to be somewhat difficult. However, I think I'll manage it in the next few days.

ok thank you for your reply. By the way, I’ve been using the version you made for 1.21.4 all along, and it’s been working perfectly without any issues.

I'm very pleased that my version works well. Today, I tried to tinker with version 1.21.8 a little, but that proved to be somewhat difficult. However, I think I'll manage it in the next few days.

Thank you very much. However, I hope you can handle this matter in your spare time, so it doesn't affect your regular work. Thank you again.

I have fixed this for myself (I added the "Okay, don't show it again"-Button), but only for 1.21.4 I don't know if the mod will work in 1.21.5. Here is the built version: https://www.dropbox.com/scl/fi/76h2jz74ylbng3ivcc0ol/RoughlyEnoughItems-18.0.8-1.21.4_fabric-fix-1784.jar?rlkey=04fgb9wj94tefzeo3n0svgkhe&e=1&st=j3woytrf&dl=0 Since this is a quick unofficial fix that was only tested briefly, I do not take any responsibility for the mod (being error-free etc.). Please use with caution.

If I get very bored these days, I might update this fix to 1.21.5 if someone really wants to have it. If so, please let me know here.

Could you please make a version for 1.21.8? As of now, the author still hasn't fixed this recipe bug.

I have fixed this for myself (I added the "Okay, don't show it again"-Button), but only for 1.21.4 I don't know if the mod will work in 1.21.5. Here is the built version: https://www.dropbox.com/scl/fi/76h2jz74ylbng3ivcc0ol/RoughlyEnoughItems-18.0.8-1.21.4_fabric-fix-1784.jar?rlkey=04fgb9wj94tefzeo3n0svgkhe&e=1&st=j3woytrf&dl=0 Since this is a quick unofficial fix that was only tested briefly, I do not take any responsibility for the mod (being error-free etc.). Please use with caution.
If I get very bored these days, I might update this fix to 1.21.5 if someone really wants to have it. If so, please let me know here.

Could you please make a version for 1.21.8? As of now, the author still hasn't fixed this recipe bug.

I can take a look at it, but so far I'm still playing with 1.21.4 and haven't really looked into newer versions yet.
If you like, you can ask the guy from the newer commit for 1.21.5 if he has the capacity to do so, as I can't promise that I'll be able to look at it anytime soon.

I have fixed this for myself (I added the "Okay, don't show it again"-Button), but only for 1.21.4 I don't know if the mod will work in 1.21.5. Here is the built version: https://www.dropbox.com/scl/fi/76h2jz74ylbng3ivcc0ol/RoughlyEnoughItems-18.0.8-1.21.4_fabric-fix-1784.jar?rlkey=04fgb9wj94tefzeo3n0svgkhe&e=1&st=j3woytrf&dl=0 Since this is a quick unofficial fix that was only tested briefly, I do not take any responsibility for the mod (being error-free etc.). Please use with caution.
If I get very bored these days, I might update this fix to 1.21.5 if someone really wants to have it. If so, please let me know here.

Could you please make a version for 1.21.8? As of now, the author still hasn't fixed this recipe bug.

I can take a look at it, but so far I'm still playing with 1.21.4 and haven't really looked into newer versions yet. If you like, you can ask the guy from the newer commit for 1.21.5 if he has the capacity to do so, as I can't promise that I'll be able to look at it anytime soon.

ok thank you for your reply. By the way, I’ve been using the version you made for 1.21.4 all along, and it’s been working perfectly without any issues.

Is it actually detecting that there are recipes that it does not know? I ran the command it says to (I am on a PurPur server) and my default recipe book is all filled out and I still get this error. I cannot find a version of REI for plugin/CraftBukkit based servers, so I cannot install anything server sided either. Does your server have data packs with custom recipes? I wonder if it is detecting that as a problem, as none of the data pack recipes I have shown up in REI.

Here is my log. Nothing seems to show up with REI that looks wrong/out of the ordinary... https://pastebin.com/U0wmDHze

Was looking for this too, a way to disable it would be great

any update on this/anyone found a solution? it's annoying to have to say ok every time I connect to a server

I have the same problem and its annoying as hell. I even think about to just dont use REI anymore, and go to JEI instead. I dont even care, if the recipes from the datapacks not show up, but this warning every time is annoying for my vanilla experience. Just an option to disable it would be fine. I dont want more than this.

I can make it an "Okay, don't show again" the second time it shows up

oh yes. that would be awesome.

PUHLEASEEEEE

This comment is not useful to this issue in the slightest. If you would like this issue fixed, bumping it with incoherent nonsense is not helpful.

If you would like, you can investigate into the problem, and give a report that can help the developers create a system to remember the choice of the user. Provide logs, etc.

PUHLEASEEEEE

My two cents:

1. Yes, please add a check box or config option that will suppress this notice. As others have mentioned, it is irritating having it pop up every time you connect to any server. I'll be honest, I looked at JEI again (out of date, oh well) simply because of this nag, it's that annoying.
2. With that said, I'd like to encourage everyone commenting to please keep things professional. This is an open source, free project, and support is volunteered. The dev(s) of this project owe you nothing, and a bit of respect goes a long ways. There is a fine line between voicing opinions/displeasure and just making questions/feature requests a negative experience for volunteer developers.

@shedaniel Thanks for your attention!

The only obvious thing that stands out in the client log is this...

[09:13:35] [REI-ReloadPlugins/ERROR]: [REI] Failed to run end-reload task for reloadable [ServerDisplayRegistryImpl] in stage [END] java.lang.NullPointerException: Cannot invoke "net.minecraft.server.MinecraftServer.method_3772()" because the return value of "dev.architectury.utils.GameInstance.getServer()" is null

at knot/me.shedaniel.rei.impl.common.registry.displays.ServerDisplayRegistryImpl.getAllSortedRecipes(ServerDisplayRegistryImpl.java:230) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.impl.common.registry.displays.ServerDisplayRegistryImpl.fillRecipes(ServerDisplayRegistryImpl.java:216) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.impl.common.registry.displays.ServerDisplayRegistryImpl.endReload(ServerDisplayRegistryImpl.java:209) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.api.common.registry.Reloadable.endReload(Reloadable.java:47) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.impl.common.plugins.PluginManagerImpl.reload(PluginManagerImpl.java:464) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.impl.common.plugins.ReloadManagerImpl.reloadPlugins0(ReloadManagerImpl.java:155) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.impl.common.plugins.ReloadManagerImpl.reloadPlugins0(ReloadManagerImpl.java:144) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at knot/me.shedaniel.rei.impl.common.plugins.ReloadManagerImpl.lambda$reloadPlugins$7(ReloadManagerImpl.java:122) ~[RoughlyEnoughItems-18.0.796-fabric.jar:?] at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572) ~[?:?] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) ~[?:?] at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?] at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

I can make it an "Okay, don't show again" the second time it shows up

The problem isn't being able to hide/dismiss the message.

The problem is that the message is still being shown even after /recipe give @a * has been run on a server.

Something has clearly changed in the newer versions that is causing this message to be shown erroneously. The root cause needs to be investigated and a proper fix implemented. It was fine in 1.21.0, for example, but not in 1.21.4.

The problem is that the message is still being shown even after /recipe give @A * has been run on a server.

That's am understandable concern, however REI has no way of knowing if it has access to all the recipes or not, the client simply doesn't know much, the data is on the server

Another question, what is the nature of this game instance? Singleplayer? Modded server? Vanilla server? Realms?

REI has no way of knowing if it has access to all the recipes or not

It must do if it was able to determine it didn't need to show that message before.

My server is fabric, but it only runs transparent mods like lithium, etc. There are no modded blocks or items being added.

In fact, a player entity contains the data element "recipeBook" which according to the wiki "Contains a JSON object detailing recipes the player has unlocked."

And when you type /recipe give @a it gives you an auto-complete listing of every available recipe on the server.

Comparing these two lists should be a simple enough task to make this determination.

It must do if it was able to determine it didn't need to show that message before.

Well this is a changed introduced in 1.21.2, when vanilla no longer sends all the recipes to the client. This is also why other recipe mods haven't updated yet.

Comparing these two lists should be a simple enough task to make this determination.

What two lists? The client only gets the list of unlocked recipes, it doesn't know the total number of recipes that only the server knows about. (Since 1.21.2 as mentioned above)
And if you mean auto-complete, that's not practical since that's only available for operators and not every recipe have conditions to unlock.

If REI is on the server, it sends all the recipes to the client, and as such is a solution to this problem.

What two lists? The client only gets the list of unlocked recipes, it doesn't know the total number of recipes that only the server knows about.

Connect to a server and start typing /recipe give @a and notice how all of the available recipes are listed for auto-completion. The client has to have gotten that list from somewhere.

It must do if it was able to determine it didn't need to show that message before.

Well this is a changed introduced in 1.21.2, when vanilla no longer sends all the recipes to the client. This is also why other recipe mods haven't updated yet.

Ok, Is there a way to enable this again? Is there a setting in the server config, either with vanilla or modded servers? My server is a Purpur server. a plugin that could do this would be useful.

also, do you know WHY this change was made? The change log simply states "The server will now only send known recipes to the client" and gives zero reason as to why this change was made, or what this change achieves.

wouldn't it be reasonable to add an option to just load all vanilla recipes, if we know the server is vanilla but don't have op?

It seems I need to unlock all recipes to be able to see the vanilla recipies, is this normal? Like if I never get eye of ender and obsidian, I see the craft for an enderchest :\

Is there no option to disable the warning? Doesn't seem to hard to add an option. Im connecting from 1.21.5 to my 16.5 server, so this message is annoying to close everytime i open the game.

This warning is really annoying, I don't wanna use the mod if it pops up constantly. I ran the command and it still shows up. Why I don't understand is why Not Enough Items doesn't need this pop up, and simply has all the data.

I have fixed this for myself (I added the "Okay, don't show it again"-Button), but only for 1.21.4 I don't know if the mod will work in 1.21.5. Here is the built version:
https://www.dropbox.com/scl/fi/76h2jz74ylbng3ivcc0ol/RoughlyEnoughItems-18.0.8-1.21.4_fabric-fix-1784.jar?rlkey=04fgb9wj94tefzeo3n0svgkhe&e=1&st=j3woytrf&dl=0
Since this is a quick unofficial fix that was only tested briefly, I do not take any responsibility for the mod (being error-free etc.).
Please use with caution.

If I get very bored these days, I might update this fix to 1.21.5 if someone really wants to have it. If so, please let me know here.

this is still a problem? this issue is months old and it seems like a simple fix

this is still a problem? this issue is months old and it seems like a simple fix

As far as I can tell, after looking through something to write the fix, it's actually not that complex to customise. I'm just not that familiar with GitHub yet, otherwise I would have created a proper fork right away.

this is still a problem? this issue is months old and it seems like a simple fix

Yes, still a problem on 1.21.5 (REI version 19.0.806-fabric)

this is still a problem? this issue is months old and it seems like a simple fix

As far as I can tell, after looking through something to write the fix, it's actually not that complex to customise. I'm just not that familiar with GitHub yet, otherwise I would have created a proper fork right away.

@Julius1638
Hey would love to see this implemented, to hopefully help you with the github issue.

1. Fork this repository.
2. Clone your fork to your local machine.
3. Make your changes.
4. Commit and push your changes to your repo
5. Go back to this original repository and open a pull request from your branch into the main branch here.
6. In your pull request, mention this issue.
   And that should be it, would love to see this fixed!

this is still a problem? this issue is months old and it seems like a simple fix

As far as I can tell, after looking through something to write the fix, it's actually not that complex to customise. I'm just not that familiar with GitHub yet, otherwise I would have created a proper fork right away.

@Julius1638 Hey would love to see this implemented, to hopefully help you with the github issue.

1. Fork this repository.

2. Clone your fork to your local machine.

3. Make your changes.

4. Commit and push your changes to your repo

5. Go back to this original repository and open a pull request from your branch into the main branch here.

6. In your pull request, mention this issue.
   And that should be it, would love to see this fixed!

@WuzzyLV
Thank you, unfortunately I don't have time at the moment. I'll give it a try on Monday, and if I manage it, I'll comment and link it here.

@WuzzyLV
I have now looked through the issue area of the mod again and found this commit here. Someone has already added the necessary setting in the mod settings to permanently hide the partial recipe message. (https://github.com/shedaniel/RoughlyEnoughItems/pull/1881/commits)
You are welcome to get it there if this commit does not work, otherwise please contact me again and I will see if I can implement it differently in order to still achieve a satisfactory result.

I have linked the two posts here for you to look at:

#1881
#1866

ok thank you for your reply. By the way, I’ve been using the version you made for 1.21.4 all along, and it’s been working perfectly without any issues.

I'm very pleased that my version works well. Today, I tried to tinker with version 1.21.8 a little, but that proved to be somewhat difficult. However, I think I'll manage it in the next few days.

hey, did you ever manage to get 1.21.7/8 working?

hey, did you ever manage to get 1.21.7/8 working?

Unfortunately, I haven't had the time to deal with it any further, but I'm now more or less forced to update to 1.21.8, and if I manage to do it in the process, I'll be happy to let you know here.
I'm a little sorry I didn't write anything else, as I unfortunately forgot.

Unfortunately, I haven't had the time to deal with it any further, but I'm now more or less forced to update to 1.21.8, and if I m

no problem whatsoever, thank you for your work on it so far!

Unfortunately, I haven't had the time to deal with it any further, but I'm now more or less forced to update to 1.21.8, and if I m

no problem whatsoever, thank you for your work on it so far!

I found time today to work on the fix and have got to the point where the message now remains suppressed for the current session in Minecraft once you click it away. I will now fix it so that it saves this and you only have to click it away once so that it never reappears.
If I manage to do that this weekend, I'll see how I can put my cloned repo on GitHub as a pull request or my own fork, and then of course I'll also make a built version available for download.

I've been struggling with GitHub today and it's totally confusing me, but I've now managed to create a fork, push it from my local code and create a release.
I hope it works without any errors. If any errors occur, please let me know.

Here is the link to the release on my fork:
Release 1.21.6-8_Fix-1784

I've been struggling with GitHub today and it's totally confusing me, but I've now managed to create a fork, push it from my local code and create a release. I hope it works without any errors. If any errors occur, please let me know.

Here is the link to the release on my fork: Release 1.21.6-8_Fix-1784

I really appreciate that you still remembered my request.
I just finished testing — when I first installed it, a recipe warning popped up, but after I closed it, it never appeared again.
Thanks again for your help!

I've been struggling with GitHub today and it's totally confusing me, but I've now managed to create a fork, push it from my local code and create a release. I hope it works without any errors. If any errors occur, please let me know.
Here is the link to the release on my fork: Release 1.21.6-8_Fix-1784

I really appreciate that you still remembered my request. I just finished testing — when I first installed it, a recipe warning popped up, but after I closed it, it never appeared again. Thanks again for your help!

I am very pleased that you appreciate my work and gave me feedback so quickly.
I also (more or less accidentally) made a commit to the correct REI repo. Maybe he will even accept the change or adapt it a little to his ideas.

By the way, you can reactivate the warning in your config folder in the roughlyenoughitems folder and then in rei_warning_config.json if you ever need it.

@shedaniel can you please (REI) update to 1.21.9/10, I always work with the mod

I've been struggling with GitHub today and it's totally confusing me, but I've now managed to create a fork, push it from my local code and create a release. I hope it works without any errors. If any errors occur, please let me know.

Here is the link to the release on my fork: Release 1.21.6-8_Fix-1784

Hi @Julius1638 do you plan to update your release for 1.21.9/10? This is the error I get with latest Architectury & Cloth

I've been struggling with GitHub today and it's totally confusing me, but I've now managed to create a fork, push it from my local code and create a release. I hope it works without any errors. If any errors occur, please let me know.
Here is the link to the release on my fork: Release 1.21.6-8_Fix-1784

Hi @Julius1638 do you plan to update your release for 1.21.9/10? This is the error I get with latest Architectury & Cloth

I don't know yet when I'll find the time, but if everything goes well, I can take a look at it over the next few days.

Is it still not added to official release?

Not as far as I know, since the bug is still marked as open.
I don't think I made a reasonable pull request, so I don't know.