Roughly Enough Items Fabric/Forge/NeoForge (REI)

Roughly Enough Items Fabric/Forge/NeoForge (REI)

40M Downloads

[Bug] Shift-Move Doesn't Respect Slot Max Count

fzzyhmstrs opened this issue ยท 0 comments

commented

What happened?

When using the auto-move "+" button in REI while holding shift, REI will transfer items beyond a slots allowable max count per getMaxItemCount. The Imbuing Table from my mod, shown in the gif down below, has a center slot with max allowable count of one, yet REI transfers all 5 diamonds.

At the beginning of the below .gif I am left-clicking to attempt to transfer the entire stack of 5, but minecraft is only permitting the 1 diamond due to the imposed limit.

I'm not very familiar with REI's internal workings, but using insertStack instead of setStack may be an avenue to preventing this behavior, as insertStack splits the provided stack based on the max the slot can take and returns the remaining ItemStack for further handling.

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

  • Visual
  • Recipe Lookup
  • Cheat Mode
  • Plugin Integration / JEI Plugin Compatibility
  • Others

Relevant log output

No error log as nothing is crashing

Anything else?

Minecraft 1.19
REI 9.1.518
Architectury 5.10.33
Cloth Cfg 7.0.73

slot_overload_trimmed

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

  • Yes, and I did not use any paste services other than GitHub Gists.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

  • Yes