Roughly Enough Items Fabric/Forge/NeoForge (REI)

Roughly Enough Items Fabric/Forge/NeoForge (REI)

40M Downloads

[Bug/Oversight] Fluid rendering uses the FluidRenderHandler instead of the FluidVariantRenderHandler

TropheusJ opened this issue ยท 3 comments

commented

What happened?

Fluid colors are queried through FluidRenderHandlerRegistry, but it should be using FluidVariantRendering when possible.
image

This prevents using NBT to adjust the color:
image

FluidVariantRendering should also be used for tooltips in FluidEntryDefinition$FluidEntryRenderer.

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

  • Visual
  • Recipe Lookup
  • Cheat Mode
  • Plugin Integration / JEI Plugin Compatibility
  • Others

Relevant log output

N/A

Anything else?

Create used to have a custom fluid entry stack renderer that worked.

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

  • Yes, and I did not use any paste services other than GitHub Gists.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

  • Yes
commented

I will close the issue here.

commented

Please open an issue for this in https://github.com/architectury/architectury-api

commented

oops, didn't realize that class was part of arch.