Roughly Enough Items Fabric/Forge/NeoForge (REI)

Roughly Enough Items Fabric/Forge/NeoForge (REI)

40M Downloads

[Bug] rendering issues with vivecraft

fayer3 opened this issue ยท 1 comments

commented

What happened?

we found the root cause for #1118 was from us, but

the screen blending modes you use mess with the alpha values of the screen, which messes with rendering the screen in vivecraft

we fixed this temporarily with mixin into the widgets rendering code, but would prefer if that would be fixed in the original source

basically replace

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

with

RenderSystem.blendFuncSeparate(GlStateManager.SourceFactor.SRC_ALPHA,
                GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA,
                GlStateManager.SourceFactor.ONE_MINUS_DST_ALPHA, GlStateManager.DestFactor.ONE);

affected files:

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

RenderSystem.blendFuncSeparate(770, 771, 1, 0);
RenderSystem.blendFunc(770, 771);

unsing RoughlyEnoughItems-8.3.529

What mod loaders are you seeing the problem on?

Fabric, Forge

What do you think this bug is of?

  • Visual
  • Recipe Lookup
  • Cheat Mode
  • Plugin Integration / JEI Plugin Compatibility
  • Others

Relevant log output

nothing relevant in the log

Anything else?

what it looks like without our mixins
grafik

link to our mixins: https://github.com/ferriarnus/VivecraftMod/tree/Multiloader-1.18/common/src/main/java/org/vivecraft/modCompatMixin/reiMixin

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

  • Yes, and I did not use any paste services other than GitHub Gists.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

  • Yes
commented

we fixed that on our side with a different approach, since multiple mods seem to do that.