Roughly Enough Items Fabric/Forge/NeoForge (REI)

Roughly Enough Items Fabric/Forge/NeoForge (REI)

40M Downloads

[Bug] [Fabric 1.18.2] Fix Z-fighting for items in tooltip components

MisterPeModder opened this issue ยท 5 comments

commented

What happened?

Items that have tooltip components (such as bundles) do not display contained items when inside the favorites section of REI.

This affects bundles and ender chests (when ShulkerBoxTooltip is installed).

Bundle in inventory:
image

Bundle in REI favorites
image

What mod loaders are you seeing the problem on?

Fabric

What do you think this bug is of?

  • Visual
  • Recipe Lookup
  • Cheat Mode
  • Plugin Integration / JEI Plugin Compatibility
  • Others

Relevant log output

No errors are present in the logs

Anything else?

No response

commented

@MisterPeModder Are there any negative implications in injecting to the ItemStack method instead of the current injection to Screen?

commented

I'm sorry, I don't get what you mean, are you talking about ShulkerBoxTooltip? If so, the issue does still occur when REI is the only non-API mod installed.

commented

I just put quick a System.out.println() in my component render method, the data is correct but the items wont display...

commented

I'm sorry, I don't get what you mean, are you talking about ShulkerBoxTooltip? If so, the issue does still occur when REI is the only non-API mod installed.

@MisterPeModder Yep, I am just asking that since REI gets the tooltip data directly from the ItemStack instead of going with the Screen method

commented

The items are actually rendered, but behind the background texture.

This seems to be a z-index issue, the only difference between the rendering in inventories and REI is:

As far as I can see, the translation just gets ignored by the item renderer, it has no methods that take a MatrixStack/PoseStack as a parameter