Roughly Enough Professions (REP)

Roughly Enough Professions (REP)

15M Downloads

[Bug]: Mod still flagged as "required" in server environment, causing crashes on server installs

totrider opened this issue ยท 2 comments

commented

General Info

  • I am running a modpack
  • I can reproduce this issue consistently in single-player
  • I can reproduce this issue consistently in multi-player
  • I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
  • I am crashing and can provide my crash report(s)
  • I am using the latest version of the mod

Loader version

Forge 47.3.0

Minecraft version

1.20.1

Mod version

latest

Java version

Whichever ATlauncher uses

Issue Description

This is what the modrinth.index.json file shoul state when exporting a mrpack format:

{
  "path": "mods/RoughlyEnoughProfessions-forge-1.20.1-2.0.2.jar",
  "hashes": {
    "sha1": "5e685b5a74d2ce0a5255822f26238ccca423943c",
    "sha512": "447ae8d96a75898ef4eef902bbe7d652d8ed0adcf323ea85a6965b2f1baec38ab0594d3c9858958173864d72bbed40c695cec974d16bcf25ff1c7663e66f64ec"
  },
  "env": {
    "server": "unsupported",
    "client": "required"
  },
  "downloads": [
    "https://cdn.modrinth.com/data/V8XJ8f5f/versions/qdLND0lY/RoughlyEnoughProfessions-forge-1.20.1-2.0.2.jar"
  ],
  "fileSize": 23204
},

But by default, it will state: ""server": "required"," instead.

It is the same issue, as I reported prior, and as far as I can see from hundreds of mods, these 2 options of "required" or "unsupported" are the only options. All other REI and JEI compatible mods have it flagged correctly as "unsupported". This does not have any effect on the mod being usable in a server environment or not, but it affects services where you download a server jar for a modpack, as it will include this mod, while REI itself is not present, causing it to crash. If server hosting has some kind of verification process to ensure it actually launched before being avaialble (the modpack), then this causes a bunch of problem and confusion.

Yes, this mod, just like JEI, REI and other related mods, may have features that work in a server environment. However, because those mods are not being included in server installs, it would be rational to also do the same for all mods that are dependent on it.

Additional Information

No response

commented

I just checked and the mod is marked as unsupported on server already. Also as of 1.21.2+ REI is likely required to be installed server-side due to vanilla no longer sending the client all available recipes

commented

I just checked and the mod is marked as unsupported on server already. Also as of 1.21.2+ REI is likely required to be installed server-side due to vanilla no longer sending the client all available recipes

Sorry for the late reply, but I only now had time to look into it, and I figured out something new.

Since you stated that it seemed correct on "your" end, I figured it might be something on my end somehow. Each time I exported the modpack format, the index file would keep on listing your mod inccorectly.

So, I tried removing and adding it to the modlist with ATlauncher, and that seems to have resolved the issue. My guess, is that the mods index file only gets updated when you install or update a mod, so since there were no reason for local changes to the mod in my directory, I suspect that the flags were not being updated as a result.