Rubidium

Rubidium

34M Downloads

1.18.2 CTM Chunk Update Incompatability

Tohricat opened this issue ยท 8 comments

commented

image
image

Chunk updates cause connected textures to randomly shift their connections.

commented

F3+A (reloading the chunks) fixes the issue, and any CTM blocks placed will look as they should and won't change with any chunk updates. New blocks placed will have the issue though.

commented

Having the same issue with Timber Frames and CTM

Before reloading chunks (F3+A or relogging):
image

After reloading chunks:
image

CTM Version: 1.18.2-1.1.4+4
Rubidium Version: 0.5.2a

commented

i think you guys should tell the ctm author becuase i was having issues myself and removed it and never had those issues with crashes etc

commented

This bug doesn't cause crashes as far as I'm aware, only the visual connection issues, and removing it defeats the purpose as connected textures won't work without it.

commented

This appears to be caused by an issue in WorldSlice. Creating a new WorldSlice in ChunkRenderCacheLocal#init fixes this issue, though this would probably result in a fairly significant performance impact and an increase in memory usage. My guess is that the connected texture states aren't being saved or looked up correctly, or something along those lines.

This at least explains why it's fixed when reloading chunks, because new WorldSlice instances are created.
I'll try to look into this more to see if it can be resolved, or if I can at least add more onto this issue.

Strangely enough, Connected Glass Mod works perfectly fine with Rubidium, so my only assumption is that something weird is happening with the way CTM handles block states, or at least the way it's stored in WorldSlice; it's hard to tell so far.

commented

I think I have tracked down the cause of this. Chisel-Team/ConnectedTexturesMod#168 (comment)

commented

@embeddedt I tried out your fix, and it looks good - but, it looks like the 1.18.2 Oculus hacks a coremod into the performBuild and gets tripped up by the local variable frame change. I came up with a slightly modified version that seems to avoid this problem, while still yielding the needed fix -
1.18/dev...mikeprimm:Rubidium:1.18/dev

commented

@mikeprimm Thanks for testing this and the note. I will go back and adjust the patches on all versions to not alter the LVT.