Rubidium

Rubidium

36M Downloads

ColorSampler is called on wrong block entity

yanang007 opened this issue ยท 1 comments

commented

Game version:

1.18.2

Mod version:

Rubidium 0.5.2a
Reliquary 1.18.2-2.0.8.1139

Step to reproduce:

  1. Install both Reliquary and Rubidium.
  2. Get into the game and place a cauldron and a mortar(any other block with block entity also works) near each other.
  3. Game crashes.

Crash report:

https://paste.ubuntu.com/p/z4ZJp9ZnTH/

Possible cause is that rubidium's color blender LinearColorBlender will call this color sampler on registered block and its neighbouring blocks, ignoring that it is registered on a specific block entity.
According to related issues in sodium repo, there has been some solution recently. I would appreciate that if you are willing take your time to port it. : )

Related Issues:

LinearColorBlender breaks any case where a precise position is required in a BlockColorProvider. (CaffeineMC/sodium-fabric#1323)
Blockentity with color not rendered correctly (CaffeineMC/sodium-fabric#895)
[1.18.2] Game crashed when apothecary cauldron is placed near other block entities with Rubidium installed (P3pp3rF1y/Reliquary#578)

commented

Seems similar to #132