Ruins (Structure Spawning System)

Ruins (Structure Spawning System)

24M Downloads

[Dynamic Lights] [1.19.2] Items with nbt data stop working a light source

studkid opened this issue ยท 3 comments

commented

If you set a light source to work with an item that can have nbt data applied to it, such as armor or tools, the item will stop emitting light once any nbt tag is added to it.

commented

So here is how these NBT strings look in the config:

"{lightLevel:15s,nameId:\"minecraft:glowstone\"}",
"{Damage:32,lightLevel:14s,nameId:\"minecraft:flint_and_steel\"}"

I implemented a check for a new tag "anyNbtMatch", with that present Dynamic Lights will stop comparing nbt equality

  • you can now configure itemstacks to ignore nbt tag equality, to shine light from items that could be
    enchanted or damaged. example: {anyNbtMatch:true,lightLevel:14s,nameId:"minecraft:flint_and_steel"}
    the important part is adding anyNbtMatch:true to the tag list

implemented for 1.19 and 1.20, new builds pushed to curse
74b2c68
149a172

commented

Technically the item doesnt match the configured item anymore - the configuration strings do include NBT tags.

There is no support for partial matches or wildcards, however. If you have a suggestion how those could be implemented?

commented

I think preferably being able to have wildcard matches would be nice if that is possible. Would like to have items that can take durability damage without effect the light aura.