Drinking milk from non vanilla bucket (e.g. Ceramics) still cures inebriation
KnightMiner opened this issue ยท 1 comments
Currently, if you use an item that applies the milk cure effect without being a milk bucket, it is able to cure inebriation. Looking at the code, it seems to be because of the weird way you make the effect incurable. Specifically, you are checking for the player drinking milk to remove the curative items instead of just removing them when adding the effects.
You could easily solve this by doing what I did in SimplyTea by just removing the curative items from the potion itself. For the negative effects caused by Inebriation, just remove the curative items when the effects are added. This also removes the side effect of drinking milk while inebriation causing normally curable effects to be incurable.
Using Rustic 1.0.15 if it helps, but the code snippets are probably better than that.