Sanguimancy

Sanguimancy

4M Downloads

Interaction with Tinkers' Construct tools with Iguana Tweaks

pjfranke opened this issue ยท 5 comments

commented

I searched, though possibly not well enough, and did not find a prior issue for this.

The Drill of the Dead ritual seems to interact strangely with Tinkers' Construct tools, when Iguana Tweaks is installed too. With Iguana Tweaks, TiC tools level up through usage, which allows the player to have modifier slots to tweak their tools (speed, sharpness, silk touch, etc).

When within range of an active Drill of the Dead, the mob kills and/or experience is picked up by the TiC tools, allowing for effectively free leveling. I don't know the code of each mod to be able to say if this is something that can or should be changed on the Sanguimancy side, or on the Iguana Tweaks side, to not pass the kills/experience, or to ignore them.

Your input would be appreciated.

Reference jadedcat/AS2Configs#59 and jadedcat/AS2Configs#179

commented

This is because when it can, the drill causes damage as if the owner did the damage, the "easiest" way to fix this without a code change is to make Sanguimancy think that the Thaumic Tinkerer mod is loaded (So empty mod container that identifiers as TT), as sanguimancy disables the "as owner" damage when TT is loaded due to crashes.

commented

I can push a quick update in a week or so to disable player damage when IT is installed as well. Tom is too busy with school and family, currently.

Edit: Unless anybody is willing to PR it, I'll happily pull a fix.

commented

If I understand right, Entoarox is suggesting a way to work around the current situation by a "Fake TT" mod, or by tweaking another mod (like Jadedcat adding something to JadedTweaks) to fake-out Sanguimancy?

But TehNut is offering to then fix the issue (not now, but soon), by pushing a change to Sanguimancy, so it recognizes the existence of IT (as it already detects TT)?

That should be sufficiently quick, and fix the exploit for everyone using Iguana Tweaks and Sanguimancy in any pack. Thanks!

commented

I took a look at the relevant code, and it doesn't look too complicated to add similar checks for IT. If it'll help, I'll give it a go. Is there a gradle server that'll auto-build it for testing, or would you prefer the person making the change do that as well locally before submitting the PR?

commented

You need to test locally. Gradle does not handle environment tests, just builds.