Scaling Health

Scaling Health

23M Downloads

Blight Death, Blacklisting and Chat Spam

Opened this issue ยท 6 comments

commented

Versions

Expected Behavior

No message to appear at all
Blacklisted mobs not to become Blight

Actual Behavior

https://imgur.com/a/MyVhIA3

  • (Link or file)
  • (Another link or file, if needed)

Steps to Reproduce the Problem

  1. Just wait for a Blight mob to die
  2. Chat gets the message
commented

seems the 'Actual Behaviour' got cut off?

when some Blight creatures die, such as squid or salmon, I get messages in chat saying
"Blight Salmon was slain by"

Because some entities die naturally, or if a death reason cant be determined then maybe the message should not appear?

I notice the config file has a blacklist for mobs that cant become blight - as you can see from the screenshot I get Salmon/Squid/Wandering Trader Blights - even tho they are blacklisted - the config is default - untouched by me

commented

or you can copy my list here:
["bat", "cat", "chicken", "cod", "cow", "donkey", "fox", "horse", "mooshroom", "mule", "ocelot", "parrot", "pig", "rabbit", "salmon", "sheep", "tropical_fish", "turtle", "villager", "wandering_trader"]

commented

So you can deactivate the message if you choose (search notifyOnBlightDeath).

Also, you will need to update the config. I changed the logic and now old mob names no longer work. If you check, your names should have a capital so
[... , Salmon, Squid, ...]
But now it requires a minuscule (salmon) and _ for spaces (so wandering_trader will work)
Please test this and let me know

commented

I deleted the config and let it regenerate the default. I thought it was weird it was showing Blight messages when the config says "#Notify everyone that a blight died in combat", and there was no combat, lol

I'll test it, but Im sure it'll be fine

commented

yeah, i need to fix those messages too but just close the issue if it fixed it

commented

all seems fine

thanks