Scannable

Scannable

Mods
20M Downloads

Requests 1.12.2 scanStayDuration support

onenok opened this issue ยท 2 comments

commented

Request to add scanStayDuration setting in 1.12.2 version.

commented

I read the src code, and I see that in li/cil/scannable/client/ScanManager.java, it is:

    @SubscribeEvent
    public void onClientTick(final TickEvent.ClientTickEvent event) 
    {

        /....../

        if (Constants.SCAN_STAY_DURATION < (int) (System.currentTimeMillis() - currentStart)) 
            {
            pendingResults.clear();

            /......./

            return;
        }

        /........../

    }

There is a Constants.SCAN_STAY_DURATION, and I see that in li/cil/scannable/common/config/Constants.java, it is:

/......../
public final class Constants {
    /......../
    // How long the results from a scan should remain visible.
    public static final int SCAN_STAY_DURATION = 10000;
    /......../
}

So, why don't just add this setting to li/cil/scannable/common/config/Settings.java?
Or am I missing something?

commented

I pulled a request: #158