Scorge

Scorge

4M Downloads

Dropping libraries for from the Language Loader

0xilly opened this issue ยท 13 comments

commented

I will be dropping these libraries from Scorge in the 1.13 release

  • Scala compiler
  • Scala reflection
  • Scala actors migration
  • Scala continuations
  • Scala parser
  • Scala xml
  • Scala swing

I might be adding

Basically just keeping it to the core library as much as possible. If there are any objections speak now.

commented

What about scala.reflect.ClassTag? It is useful in various situations (espc. its runtimeClass method), and is used in some scala mods (just to name two: OpenComputers, bdlib). For the other libs: they are indeed basically useless for MC modding.

commented

I'm not against it, I would like to hear from bdew or or from the MightyPirates team for more of their input I'll try and contact them later this week.

commented

ClassTag resides in the core library though, so not a problem. As for 2.13, will the parallel collections be included? I currently use them to parallelize an entity-like system. It won't be in the core library in 2.13, but it is now.

commented

Also, what about adding scala-java8-compat. Seeing as Forge might use more Java 8 stuff like CompleteableFuture for 1.13, so it would be nice to be able to convert that too and from Future easily. There are some other goodies in there as well.

commented

Ah, didn't know that, thx @Katrix

Additionally, it might be interesting to discuss if one should add the following libraries for 2.13:

commented

I see little reason for including compat as it's main purpose is to allow cross-building, which isn't really a concern for us. I would love to have contrib around though.

commented

Well, it would be nice to have the same Scala code for multiple MC versions, as 1.7.10 - 1.12 will continue to use 2.11.1 (correct me if I am wrong).

commented

I'll worry about parallel collections and contrib once 2.13 drops(odds are ill add it) because I don't plan on supporting milestones. As for collection compact I still don't really see how that would be useful for us in an MC modding context when we have to rewrite everything for almost every new MC release as is.

commented

closed by 12ed751 please bring up library requests as new issues
also see https://github.com/MinecraftForge/Scorge#shaded-libraries

commented

Is Scorg going to continue packaging typesafe.Config?

At the moment mis-matching versions of typesafe.config is causing SpongeAPI some pain, as on SpongeVanilla we have v1.3 of typesafe.config, and on SpongeForge we had a conflicting version. The 'solution' at the time was to shadow typesafe.config in SpongeForge only, which caused incompatibilities between plugins that worked well on SpongeVanilla but do not work on SpongeForge.

SpongePowered/Sponge#1391

We would appreciate whatever Scala adapter that is used on Forge to supply a version newer then 1.3 or maybe not supply it at all? (but then would we have worse problems?)

commented

It's outside the scope of Scorge to carry typesafe.Config so it's going to be dropped and already has been dropped in cpw's fml overhaul branch.

commented

@illyohs Do you know what the current state is for 1.12?

commented

It stayed in, it was to late into the dev cycle of forge for it to be removed in 1.12 when the PR was originally made.